1221227 - Don't delete history/bookmarks items that were (also) created locally

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Sync, defect, P1)

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] michielbdejong:1221227-created-locally > mozilla-b2g:master

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

Could you explain the reasoning behind this patch, please? Also in code comments would be highly appreciated. The whole adapters/clearing stuff is becoming quite complicated with some edge cases and different behavior in phone and TV (and in readonly and readwrite modes), we really need to document this stuff properly.

Also, is this still going to be the case when we move to a readwrite model? Or is this just a temporary measure for the readonly model?

Comment 3

[Michiel de Jong [:michielbdejong]]

You're right, I have to add more code comments.

We will still need this if users select the readonly option in settings, I think, unless we don't provide that setting.

In any case, I'll describe all these edge cases and special behaviors, and why they work the way they work as part of bug 1218278.

Comment 4

[Michiel de Jong [:michielbdejong]]

Follow-up ticket for improving efficiency is bug 1223418.

Comment 5

[Michiel de Jong [:michielbdejong]]

Code comments added.

Comment 6

[Michiel de Jong [:michielbdejong]]

Sorry, that follow-up is unrelated to this bug.

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8683133 [details] [review]
[gaia] michielbdejong:1221227-created-locally > mozilla-b2g:master

Thank you Michiel. I left a comment on GitHub.

Comment 8

[Michiel de Jong [:michielbdejong]]

Thanks! Responded.

Comment 9

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/c6fe9fbc2081876c7beb9a05978484e8b9660d99