Closed Bug 1221275 Opened 4 years ago Closed 4 years ago

Bookmark toolbar background has light color in firefox developer edition

Categories

(Firefox :: Theme, defect)

44 Branch
All
Windows
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 45
Tracking Status
firefox44 + verified
firefox45 --- verified

People

(Reporter: breul99, Assigned: Gijs)

References

Details

(Keywords: regression)

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:44.0) Gecko/20100101 Firefox/44.0
Build ID: 20151103004217

Steps to reproduce:

Open FF


Actual results:

see screen shot, the background of the toolbar is not the right color


Expected results:

The background should be the same color as the url toolbar
This is a change from bug 1184651 / https://hg.mozilla.org/releases/mozilla-aurora/rev/fcf23377f9c3
Blocks: 1184651
Status: UNCONFIRMED → NEW
Component: Untriaged → Theme
Ever confirmed: true
Summary: Bookmark toolbar background is the wrong color in FF dev 44 → Bookmark toolbar background has light color in firefox developer edition
[Tracking Requested - why for this release]: visual regression
Has STR: --- → yes
Keywords: regression
OS: Unspecified → Windows
Hardware: Unspecified → All
Brian, do you have cycles to look at this?
Flags: needinfo?(bgrinstead)
Just going to be selfish and take this.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(bgrinstead)
Bug 1221275 - override background-images for toolbars when setting devedition colors, r?jaws
Attachment #8683301 - Flags: review?(jaws)
https://reviewboard.mozilla.org/r/24273/#review21759

::: browser/themes/shared/devedition.inc.css:166
(Diff revision 1)
> -  background-color: var(--chrome-secondary-background-color) !important;
> +  background: var(--chrome-secondary-background-color) !important;

If you're making this change, this override: https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/devedition.inc.css#248 can be removed.
Comment on attachment 8683301 [details]
MozReview Request: Bug 1221275 - override background image on all non-menubar/tabs toolbars, r?jaws

https://reviewboard.mozilla.org/r/24273/#review22237

::: browser/themes/shared/devedition.inc.css:166
(Diff revision 1)
> -  background-color: var(--chrome-secondary-background-color) !important;
> +  background: var(--chrome-secondary-background-color) !important;

I would prefer that the background-image override is explicit and to not use shorthand.
Attachment #8683301 - Flags: review?(jaws)
Attachment #8683301 - Attachment description: MozReview Request: Bug 1221275 - override background-images for toolbars when setting devedition colors, r?jaws → MozReview Request: Bug 1221275 - override background image on all non-menubar/tabs toolbars, r?jaws
Attachment #8683301 - Flags: review?(jaws)
Comment on attachment 8683301 [details]
MozReview Request: Bug 1221275 - override background image on all non-menubar/tabs toolbars, r?jaws

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24273/diff/1-2/
Comment on attachment 8683301 [details]
MozReview Request: Bug 1221275 - override background image on all non-menubar/tabs toolbars, r?jaws

https://reviewboard.mozilla.org/r/24273/#review22305

Great, I like this diff a lot better too as it shows the fix much clearer IMO.
Attachment #8683301 - Flags: review?(jaws) → review+
https://hg.mozilla.org/mozilla-central/rev/363d867931b5
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
QA Whiteboard: [good first verify]
Reproduced the bug in firefox aurora 44.0a2 (2015-11-03) on windows 10 x64

Verified as fixed with latest firefox nightly 45.0a1 (Build ID: 20151117030242)

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:45.0) Gecko/20100101 Firefox/45.0
Can this be uplifted to Dev Ed ?
Flags: needinfo?(gijskruitbosch+bugs)
Comment on attachment 8683301 [details]
MozReview Request: Bug 1221275 - override background image on all non-menubar/tabs toolbars, r?jaws

Approval Request Comment
[Feature/regressing bug #]: devedition theme / bug 1184651
[User impact if declined]: bookmarks toolbar has the wrong color
[Describe test coverage new/current, TreeHerder]: nope
[Risks and why]: very low, very specific CSS-only patch that only affects the devedition theme
[String/UUID change made/needed]: no.
Flags: needinfo?(gijskruitbosch+bugs)
Attachment #8683301 - Flags: approval-mozilla-aurora?
Reproduced this bug by following comment 0 on Linux, 64 Bit with Firefox Aurora 44.0a2 (2015-11-03)

This Bug is now verified as fixed on Latest Firefox Nightly 45.0a1 (2015-11-18)

Build ID: 20151118030232
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0
QA Whiteboard: [good first verify] → [good first verify][bugday-20151118]
Updating status based on comment 13 and 16.
Status: RESOLVED → VERIFIED
Comment on attachment 8683301 [details]
MozReview Request: Bug 1221275 - override background image on all non-menubar/tabs toolbars, r?jaws

Fixes that have been verified are always the safest to uplift. Let's land this on Aurora44.
Attachment #8683301 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Tracked as this is a regression that occurred in 44.
Reproduced this bug on windows 8.1 (64 bit) in Firefox  Aurora 44.0a2

and verified as fixed on Firefox latest nightly 45.0a1 

Build ID :20151117030242
User Agent :Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0
Tested on latest Aurora 44.0a2 on windows 10 x86...
it works for me.
You need to log in before you can comment on or make changes to this bug.