1221275 - Bookmark toolbar background has light color in firefox developer edition

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[breul99]

Attachment: 2015-11-03 14_51_27-.png

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:44.0) Gecko/20100101 Firefox/44.0
Build ID: 20151103004217

Steps to reproduce:

Open FF


Actual results:

see screen shot, the background of the toolbar is not the right color


Expected results:

The background should be the same color as the url toolbar

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This is a change from bug 1184651 / https://hg.mozilla.org/releases/mozilla-aurora/rev/fcf23377f9c3

Comment 2

[Tim Nguyen :ntim]

[Tracking Requested - why for this release]: visual regression

Comment 4

[:Gijs (he/him)]

Brian, do you have cycles to look at this?

Comment 5

[:Gijs (he/him)]

Just going to be selfish and take this.

Comment 6

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1221275 - override background image on all non-menubar/tabs toolbars, r?jaws

Bug 1221275 - override background-images for toolbars when setting devedition colors, r?jaws

Comment 7

[Tim Nguyen :ntim]

https://reviewboard.mozilla.org/r/24273/#review21759

::: browser/themes/shared/devedition.inc.css:166
(Diff revision 1)
> -  background-color: var(--chrome-secondary-background-color) !important;
> +  background: var(--chrome-secondary-background-color) !important;

If you're making this change, this override: https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/devedition.inc.css#248 can be removed.

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8683301 [details]
MozReview Request: Bug 1221275 - override background image on all non-menubar/tabs toolbars, r?jaws

https://reviewboard.mozilla.org/r/24273/#review22237

::: browser/themes/shared/devedition.inc.css:166
(Diff revision 1)
> -  background-color: var(--chrome-secondary-background-color) !important;
> +  background: var(--chrome-secondary-background-color) !important;

I would prefer that the background-image override is explicit and to not use shorthand.

Comment 9

[:Gijs (he/him)]

Comment on attachment 8683301 [details]
MozReview Request: Bug 1221275 - override background image on all non-menubar/tabs toolbars, r?jaws

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24273/diff/1-2/

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8683301 [details]
MozReview Request: Bug 1221275 - override background image on all non-menubar/tabs toolbars, r?jaws

https://reviewboard.mozilla.org/r/24273/#review22305

Great, I like this diff a lot better too as it shows the fix much clearer IMO.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/363d867931b5

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/363d867931b5

Comment 13

[Rezaul Huque Nayeem]

Reproduced the bug in firefox aurora 44.0a2 (2015-11-03) on windows 10 x64

Verified as fixed with latest firefox nightly 45.0a1 (Build ID: 20151117030242)

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:45.0) Gecko/20100101 Firefox/45.0

Comment 14

[Tim Nguyen :ntim]

Can this be uplifted to Dev Ed ?

Comment 15

[:Gijs (he/him)]

Comment on attachment 8683301 [details]
MozReview Request: Bug 1221275 - override background image on all non-menubar/tabs toolbars, r?jaws

Approval Request Comment
[Feature/regressing bug #]: devedition theme / bug 1184651
[User impact if declined]: bookmarks toolbar has the wrong color
[Describe test coverage new/current, TreeHerder]: nope
[Risks and why]: very low, very specific CSS-only patch that only affects the devedition theme
[String/UUID change made/needed]: no.

Comment 16

[Nazir Ahmed Sabbir [:NaSb]]

Reproduced this bug by following comment 0 on Linux, 64 Bit with Firefox Aurora 44.0a2 (2015-11-03)

This Bug is now verified as fixed on Latest Firefox Nightly 45.0a1 (2015-11-18)

Build ID: 20151118030232
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0

Comment 17

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Updating status based on comment 13 and 16.

Comment 18

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8683301 [details]
MozReview Request: Bug 1221275 - override background image on all non-menubar/tabs toolbars, r?jaws

Fixes that have been verified are always the safest to uplift. Let's land this on Aurora44.

Comment 19

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tracked as this is a regression that occurred in 44.

Comment 20

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/86415471ce2c

Comment 21

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/86415471ce2c

Comment 22

[Md. Ehsanul Hassan]

Reproduced this bug on windows 8.1 (64 bit) in Firefox  Aurora 44.0a2

and verified as fixed on Firefox latest nightly 45.0a1 

Build ID :20151117030242
User Agent :Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0

Comment 23

[Wahiduzzaman Hridoy]

Tested on latest Aurora 44.0a2 on windows 10 x86...
it works for me.