122133 - Do a CoalesceDir in relative URLs the same way as in absolute URLs

Status: VERIFIED FIXED

(Core :: Networking, defect)

Description

[Andreas Otte]

This is a spinoff from bug 119071. As a result of the patch to that bug
CoalesceDirs in relative URLs works different form CoalesceDirs in absolute
URLs. I don't think that should be the final word on this, I think CoalesceDirs
for relative URLs should work the same way as for absolute URLs.

RFC 2396 says about resolving relative URLs:

If the resulting buffer string still begins with one or more
complete path segments of "..", then the reference is
considered to be in error.  Implementations may handle this
error by retaining these components in the resolved path (i.e.,
treating them as part of the final URI), by removing them from
the resolved path (i.e., discarding relative levels above the
root), or by avoiding traversal of the reference.

Currently we do option one (retaining) for absolute URLs and option two
(discarding) for relative URLs. I think beginning ".." should be retained for
relative URLs too, because that would expose badly written html, otherwise the
".." gets dropped and sometimes mozilla gets it right by accident and nobody
notices bad html.

Comment 1

[Andreas Otte]

Attachment: patch to handle the CoalesceDir on relative urls the same way as on absolute urls

Comment 2

[Andreas Otte]

With the checkin for bug 207298 CoalesceDirs in relative URLs works now the same
as CoalesceDirs in absolute URLs. Instead it depends on the protocol (currently
only ftp) to retain the .. or not.

Comment 3

[Andreas Otte]

marking fixed

Comment 4

[benc]

V/fixed.
Mac OS X, Mozilla 1.6b 20040111.