1221414 - Remove PL_DHASH_STOP usage in comm-central

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Nicholas Nethercote [inactive]]

This goes hand-in-hand with bug 1221376.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Remove PL_DHASH_STOP usage in comm-central

This compiles but I haven't done any testing.

Comment 2

[Philip Chee]

Does this overlap with Bug 1187188?

Comment 3

[Nicholas Nethercote [inactive]]

(In reply to Philip Chee from comment #2)
> Does this overlap with Bug 1187188?

Yes. That's about removing all the Enumerate/EnumerateRead calls; this is about just the ones that use PL_DHASH_STOP. You could move this patch over to that bug and change its log message accordingly, if you like.

Comment 4

[Kent James (:rkent)]

Comment on attachment 8682905 [details] [diff] [review]
Remove PL_DHASH_STOP usage in comm-central

Review of attachment 8682905 [details] [diff] [review]:
-----------------------------------------------------------------

I checked the changes line-by-line, and ran a smoke test of the compiled version. Looks good to me.

The comm-central tree is closed at the moment, so I cannot land this. But if urgent for you we might be able to make an exception.

Comment 5

[Nicholas Nethercote [inactive]]

No urgency. A bunch of patches across several bugs must land before bug 1221376 can land, and many of those patches are still awaiting review.

Comment 6

[Kent James (:rkent)]

https://hg.mozilla.org/comm-central/rev/7006132e6f68