1187188 - Replace nsBaseHashtable::Enumerate() calls in comm-central with iterators

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Nicholas Nethercote [inactive]]

Because iterators are so much nicer than enumerate functions.

There are 13 occurrences of Enumerate() in comm-central:

- 1 in mailnews/addrbook/src/nsAbMDBDirectory.cpp
- 1 in mailnews/base/util/nsMsgIncomingServer.cpp
- 11 in mailnews/base/src/nsMsgAccountManager.cpp

A note to the assignee: to preserve existing behaviour, you should probably use
nsBaseHashtable::Iterator::Data() rather than nsBaseHashtable::Iterator::UserData(). (The latter should be used when replacing nsBaseHashtable::EnumerateRead()).

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Replace nsBaseHashtable::Enumerate() calls in comm-central with iterators

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Replace nsBaseHashtable::Enumerate() calls in comm-central with iterators

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: (part 3) - Replace nsBaseHashtable::Enumerate() calls in comm-central with iterators

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: (part 4) - Replace nsBaseHashtable::Enumerate() calls in comm-central with iterators

Comment 5

[Nicholas Nethercote [inactive]]

I've checked that these patches compile but have not done any testing. Please check them carefully before landing. I will land the patches that remove the old enumeration functions in a couple of days, to give you some time to land these first.

This is the last of my PLDHashTable/nsTHashtable/nsBaseHashtable refactorings for now :)

Comment 6

[Kent James (:rkent)]

Thanks or doing these, Nicholas. Just started to look at them today, it's been hectic!

Comment 7

[Kent James (:rkent)]

http://hg.mozilla.org/comm-central/rev/ecea79aeec5e
http://hg.mozilla.org/comm-central/rev/4da904c02e1a
http://hg.mozilla.org/comm-central/rev/1cb65d027ed4
http://hg.mozilla.org/comm-central/rev/eaa2499c8877