Closed Bug 1221549 Opened 9 years ago Closed 9 years ago

Package sourcemap with the same layout than source tree

Categories

(DevTools :: General, defect)

defect
Not set
normal

Tracking

(firefox45 fixed)

RESOLVED FIXED
Firefox 45
Tracking Status
firefox45 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(1 file)

Similar to bug 1219723, but for sourcemap.
Required for mapping devtools URLs to local checkout.
Attached patch patch v1Splinter Review
Attachment #8683349 - Flags: review?(jryans)
Comment on attachment 8683349 [details] [diff] [review]
patch v1

Review of attachment 8683349 [details] [diff] [review]:
-----------------------------------------------------------------

Seems fine since it's just a packaging change.  Thanks!

::: devtools/shared/worker/loader.js
@@ +502,5 @@
>      "": "resource://gre/modules/commonjs/",
>      // ⚠ DISCUSSION ON DEV-DEVELOPER-TOOLS REQUIRED BEFORE MODIFYING ⚠
>      "devtools": "resource://devtools",
>      // ⚠ DISCUSSION ON DEV-DEVELOPER-TOOLS REQUIRED BEFORE MODIFYING ⚠
>      "devtools/client": "resource://devtools/client",

Looks like we could also remove this redundant line...  Just a thought, while we're here...
Attachment #8683349 - Flags: review?(jryans) → review+
https://hg.mozilla.org/integration/fx-team/rev/04f3ff8ed1870ca55fd91a7d7de5de308ef2c848
Bug 1221549 - Package source-map with the same layout than source tree r=jryans
https://hg.mozilla.org/mozilla-central/rev/04f3ff8ed187
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: