Closed
Bug 1221549
Opened 9 years ago
Closed 9 years ago
Package sourcemap with the same layout than source tree
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(firefox45 fixed)
RESOLVED
FIXED
Firefox 45
Tracking | Status | |
---|---|---|
firefox45 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(1 file)
4.09 KB,
patch
|
jryans
:
review+
|
Details | Diff | Splinter Review |
Similar to bug 1219723, but for sourcemap. Required for mapping devtools URLs to local checkout.
Assignee | ||
Comment 1•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6135bfde6688
Assignee | ||
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8e37b1197be
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8683349 -
Flags: review?(jryans)
Comment on attachment 8683349 [details] [diff] [review] patch v1 Review of attachment 8683349 [details] [diff] [review]: ----------------------------------------------------------------- Seems fine since it's just a packaging change. Thanks! ::: devtools/shared/worker/loader.js @@ +502,5 @@ > "": "resource://gre/modules/commonjs/", > // ⚠ DISCUSSION ON DEV-DEVELOPER-TOOLS REQUIRED BEFORE MODIFYING ⚠ > "devtools": "resource://devtools", > // ⚠ DISCUSSION ON DEV-DEVELOPER-TOOLS REQUIRED BEFORE MODIFYING ⚠ > "devtools/client": "resource://devtools/client", Looks like we could also remove this redundant line... Just a thought, while we're here...
Attachment #8683349 -
Flags: review?(jryans) → review+
Assignee | ||
Comment 5•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3eb46621293b
Assignee | ||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/04f3ff8ed1870ca55fd91a7d7de5de308ef2c848 Bug 1221549 - Package source-map with the same layout than source tree r=jryans
Comment 7•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/04f3ff8ed187
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox45:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•