1221591 - Create LoginsListViewController to display a list of logins with search/indexing options

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Stephan Leroux [:sleroux]]

Attachment: Screenshot 2015-11-04 11.29.10.png

This screen will be used to display all of the user's logins and provided functionality for filtering by username and quick scrolling using an index view. See attached screenshot for details.

Comment 1

[Stephan Leroux [:sleroux]]

When the user scrolls down the list, should the search area scroll away with the list or be a fixed header?

Comment 2

[Robin Andersen [:tecgirl]]

(In reply to Stephan Leroux [:sleroux] from comment #1)
> When the user scrolls down the list, should the search area scroll away with
> the list or be a fixed header?

Fixed! Thank you :)

Comment 3

[Stephan Leroux [:sleroux]]

Is there a design for a 'No results found' view when searching and there isn't any matching results?

Comment 4

[Stephan Leroux [:sleroux]]

Opened https://bugzilla.mozilla.org/show_bug.cgi?id=1233183 to track no results page. For now I can push up the screen without it for code/ux review.

Comment 5

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1365

Pull together the widgets I already landed for the login cell and search widget to build the login list view with filtering/index view.

Comment 6

[Robin Andersen [:tecgirl]]

Comment on attachment 8699486 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1365

Looks good!

One nit: we should sort by domain and not sub-domain. For example;  https://login.mozilla.org would sort under M rather than L

Comment 7

[Robin Andersen [:tecgirl]]

(In reply to Stephan Leroux [:sleroux] from comment #3)
> Is there a design for a 'No results found' view when searching and there
> isn't any matching results?

Not yet. Standby :)

Comment 8

[Robin Andersen [:tecgirl]]

(In reply to Stephan Leroux [:sleroux] from comment #1)
> When the user scrolls down the list, should the search area scroll away with
> the list or be a fixed header?

The sticky header is good as you have it.

Comment 9

[Stephan Leroux [:sleroux]]

Just landed this and forgot to fix the domain nit. I'll file another bug :(

Master 534e509f0cb921b2dbae3b4e83f5dcd2c1756ca2

Comment 10

[Stephan Leroux [:sleroux]]

Follow up bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1233724