1233183 - Show 'No Results View' when no results are returned from searching in the login list view

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Stephan Leroux [:sleroux]]

We should display an overlay/message to the user saying that no matching results were found when searching the logins list view.

Comment 1

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1393

Comment 2

[Brian Nicholson (:bnicholson)]

Comment on attachment 8703773 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1393

Cool beans.

Comment 3

[Robin Andersen [:tecgirl]]

Comment on attachment 8703773 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1393

LGTM, but could we move it up a bit? See the vertical positioning of our other empty panel states.

I'll work on making better UI (and when we're not string frozen), but this is good for now.

Comment 4

[Stephan Leroux [:sleroux]]

Attachment: Before

Comment 5

[Stephan Leroux [:sleroux]]

Attachment: After

I've adjusted the title so now it's visually balanced with the search bar white space. How does this look?

Comment 6

[Robin Andersen [:tecgirl]]

(In reply to Stephan Leroux [:sleroux] from comment #5)
> Created attachment 8705139 [details]
> After
> 
> I've adjusted the title so now it's visually balanced with the search bar
> white space. How does this look?

LGTM

Comment 7

[Stephan Leroux [:sleroux]]

master 75d654aba047ad8ea43d53755d3581df6a4b6eba