1221851 - Parameter description for "password_complexity" is incorrect

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Comment 1

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1221851_1.patch

Somehow overlooked this.

Comment 2

[:glob ✱]

Comment on attachment 8683450 [details] [diff] [review]
1221851_1.patch

Review of attachment 8683450 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

::: template/en/default/admin/params/auth.html.tmpl
@@ +137,4 @@
>      "Set the complexity required for passwords. In all cases must the passwords " _
>      "be at least ${constants.USER_PASSWORD_MIN_LENGTH} characters long." _
>      "<ul><li>no_constraints - No complexity required.</li>" _
> +    "<li>bmo - Passwords must meet any 3 of the following conditions: " _

i think this would be clearer if it were "..at least three.." instead of "..any 3.."

Comment 3

[:glob ✱]

since this is a fixup bug, could you also fix the warnings generated by the tests:

ok 636 - --WARNING template/en/default/global/user-error.html.tmpl has 3 unused error tag(s):
# user error tag 'passwords_dont_match' is defined at line(s) (1487) but is not used anywhere
# user error tag 'password_not_complex' is defined at line(s) (1504) but is not used anywhere
# user error tag 'password_too_short' is defined at line(s) (1495) but is not used anywhere

Comment 4

[Dylan Hardison [:dylan] (he/him)]

I don't know how you're seeing that. password_* error tags are supposed to be ignored by that test -- and I don't see those (with and without "bz fix")

Comment 5

[Dylan Hardison [:dylan] (he/him)]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   c7a2cf0..67d9618  master -> master

Will leave bug open while I check on those in taskcluster...

Comment 6

[Dylan Hardison [:dylan] (he/him)]

Filed as bug 1221860