1221917 - When pushing something to the try server, the e-mail contains an incorrect link to the built binaries.

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

Example:

Once completed, builds and logs will be available at:
https://ftp-ssl.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-4448482b00e7

Correct is:
https://ftp-ssl.mozilla.org/pub/firefox/try-builds/[e-mail]-4448482b00e71c711522a130d6c772d8bcc42670/

Comment 1

[Jorg K (CEST = GMT+2)]

Sorry if it's a duplicate and sorry for potentially CC'ing the wrong person. It's just annoying having to search for the results of your submission.

Most likely this is caused be the change-over to S3.

Comment 2

[Nick Thomas [:nthomas] (UTC+12)]

Thanks, it is a regression from bug 1213721.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [buildbotcustom] Fix hash length

Uses the short hash for user-facing strings like the subject and treeherder url (following the push hook on hg.m.o), while using the 40 character hash for the package directory and mail references.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [buildbot-configs] Update hosts+path

* switches away from ftp-ssl.mozilla.org to archive.mozilla.org for production, and equivalent change for staging
* changes /pub/mozilla.org to /pub in paths (avoiding a redirect on each request)

Comment 5

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8684712 [details] [diff] [review]
[buildbot-configs] Update hosts+path

http://hg.mozilla.org/build/buildbot-configs/rev/1ef5a49fb8e0

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8684711 [details] [diff] [review]
[buildbotcustom] Fix hash length

http://hg.mozilla.org/build/buildbotcustom/rev/5137dacda726

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Test push returns email with body:

Thank you for your try submission. It's the best!

Results will be displayed on Treeherder as they come in:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=70fe6d20120d

Once completed, builds and logs will be available at:
https://archive.mozilla.org/pub/firefox/try-builds/[e-mail]-70fe6d20120d8e9a368989b4f8d5c1c5dc167dea

Summary:
  * try: -b o -p linux,macosx64,android-api-11 -u none -t none
----------------

That's missing a trailing / on the archive link, boo.

https://hg.mozilla.org/build/buildbot-configs/rev/3f00d9ec8fa2
https://hg.mozilla.org/build/buildbot-configs/rev/919e4e945251

Lets leave it there.

Comment 8

[Jorg K (CEST = GMT+2)]

Hmm, this is one I've just pushed for C-C:

Results will be displayed on Treeherder as they come in:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=a6c91947e376

Once completed, builds and logs will be available at:
https://archive.mozilla.org/pub/thunderbird/try-builds//[e-mail]-a6c91947e376246f24a0adf94099b4dd6131581e

There is a double slash in the middle and the slash at the end is missing.

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

You're right, my patch 3f00d9ec8fa2 was incorrect. Thanks for the report.

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [buildbot-configs] Shuffle / around like we're the titanic, or something

This backs out my patch which added a trailing / to package_url, which caused the double // reported in comment #8. Instead it adds one to package_dir so that it ends up at the end of the url, which was the original intention.

Both of these parameters are only used for try jobs, see https://dxr.mozilla.org/build-central/source/buildbotcustom/misc.py#1261 and 1605.

Comment 11

[Jorg K (CEST = GMT+2)]

Can I annoy you one more time. This is regarding a C-C push.

In the e-mail I was notified of
https://archive.mozilla.org/pub/thunderbird/try-builds//[e-mail]-49149a684ab49e2ae1939b7600c1dc0d21268259
OK, we agree that this would be correct:
https://archive.mozilla.org/pub/thunderbird/try-builds/[e-mail]-49149a684ab49e2ae1939b7600c1dc0d21268259/

However, the more useful stuff (executables) is in:
https://archive.mozilla.org/pub/thunderbird/try-builds/[e-mail]-49149a684ab4/

Shouldn't both links be sent in the e-mail?

Comment 12

[Nick Thomas [:nthomas] (UTC+12)]

Attachment: [buildbotcustom] Upload try-comm-central using long hashes

got_version is 12 chars long, version is 40 chars, eg http://buildbot-master79.build.mozilla.org:8101/builders/TB%20WINNT%205.2%20try-comm-central%20build/builds/8

This only affects Thunderbird builds, as Firefox moved to mozharness.

Comment 13

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8688166 [details] [diff] [review]
[buildbot-configs] Shuffle / around like we're the titanic, or something

https://hg.mozilla.org/build/buildbot-configs/rev/a639a3066489 - not merged to production yet.

Comment 14

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8688672 [details] [diff] [review]
[buildbotcustom] Upload try-comm-central using long hashes

https://hg.mozilla.org/build/buildbotcustom/rev/950c3923f2a1
https://hg.mozilla.org/build/buildbotcustom/rev/a061049e67ed (merge to prod)

Attachment 86888166 got merged to prod at https://hg.mozilla.org/build/buildbot-configs/rev/cff817c6f375

Comment 15

[Nick Thomas [:nthomas] (UTC+12)]

I did a test push and the email told me about
  https://archive.mozilla.org/pub/firefox/try-builds/[e-mail]-c633fcefa91f51cbeafa625631228d076b1f2688/
and the logs got uploaded there. The binaries I know were already working for Firefox.

Jorg G, is Thunderbird Try working now ?

Comment 16

[Jorg K (CEST = GMT+2)]

Thanks, I'll check it tomorrow, 12:57 AM here now.

I do FF pushes as well, so logs and binaries will go to the same spot identified by the 40 characters at the end?

Comment 17

[Nick Thomas [:nthomas] (UTC+12)]

Yep, except there's still an issue with mobile in bug 1217742.

Comment 18

[Jorg K (CEST = GMT+2)]

I did another C-C push and this time got this message:

Once completed, builds and logs will be available at:
https://archive.mozilla.org/pub/thunderbird/try-builds/[e-mail]-d2556d77dd2be7c315c53bf3760faa31a06f6298/

The process completed and I found the results where specified. So it's all good now ;-)

Comment 19

[Nick Thomas [:nthomas] (UTC+12)]

Awesome, thanks for your help.