Closed
Bug 1221998
Opened 11 years ago
Closed 11 years ago
Make sure localconfig is generated deterministically
Categories
(bugzilla.mozilla.org :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: gozer, Assigned: gozer)
References
Details
Attachments
(1 file, 1 obsolete file)
|
512 bytes,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
Since the localparams override patch landed in bug 1218457, the content of localparams isn't deterministic anymore, specifically, %param_override
This is because using Data::Dumper to dump a hash will return it in hash order by default, which is not deterministic.
You need $Data::Dumper::Sortkeys = 1 for this to work.
This is causing me tons of problems, so submitting the fix
Attachment #8683654 -
Flags: review?(dkl)
Comment 1•11 years ago
|
||
Comment on attachment 8683654 [details] [diff] [review]
Sort hash keys when updating localconfig
Review of attachment 8683654 [details] [diff] [review]:
-----------------------------------------------------------------
::: Bugzilla/Install/Localconfig.pm
@@ +280,4 @@
> chomp($desc);
> # Make the description into a comment.
> $desc =~ s/^/# /mg;
> + local $Data::Dumper::Sortkeys = 1;
Move outside of the foreach loop.
Attachment #8683654 -
Flags: review?(dkl) → review+
| Assignee | ||
Comment 2•11 years ago
|
||
Moved $Data::Dumper::Sortkeys out of the main loop
Added a comment.
Attachment #8683654 -
Attachment is obsolete: true
Attachment #8683849 -
Flags: review?(dkl)
Comment 3•11 years ago
|
||
Comment on attachment 8683849 [details] [diff] [review]
Sort hash keys when updating localconfig v2
r=dkl
Attachment #8683849 -
Flags: review?(dkl) → review+
Comment 4•11 years ago
|
||
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
534fc21..60bde01 master -> master
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
| Assignee | ||
Comment 5•11 years ago
|
||
(In reply to David Lawrence [:dkl] from comment #4)
> To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
> 534fc21..60bde01 master -> master
Awesome! What do I need to do to have that merged to the production branch so I can deploy this?
Comment 6•11 years ago
|
||
(In reply to Philippe M. Chiasson (:gozer) from comment #5)
> (In reply to David Lawrence [:dkl] from comment #4)
> > To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
> > 534fc21..60bde01 master -> master
>
> Awesome! What do I need to do to have that merged to the production branch
> so I can deploy this?
wait for the push next week.
You need to log in
before you can comment on or make changes to this bug.
Description
•