1222028 - Large favicon in hello panel for some websites

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[Bogdan Maris, Desktop Test Engineering]

Attachment: Screenshot showing the issue

Affected builds:
- latest Aurora 44.0a2
- latest Nighty 45.0a1

Unaffected builds:
- Firefox 43 beta 1 (icon is small)

Affected OS`s:
- Windows 7 64-bit
- Ubuntu 14.04 32-bit
- Mac OS X 10.11.1

STR:
1. Start Firefox
2. Click Hello icon
3. Click Get started
4. Visit a webpage with large favicon (eg: https://vulcun.com)
5. Start a conversation
6. Click Hello icon

Expected results: A smaller favicon is shown in Hello panel.
Don't know exactly the maximum size of the favicons supported in Hello panel

Actual results: A large favicon is shown in Hello panel (size: 34x34).

Notes:
- Screenshot attached showing the issue.
- This is a regression, I just quickly checked on an old Nightly I had installed (2015-05-15) and the icon is replaced with a blank dotted square, will need to investigate further.

Comment 1

[Bogdan Maris, Desktop Test Engineering]

m-c:

Last good revision: fc706d376f0658e560a59c3dd520437b18e8c4a4 (2015-10-28)
First bad revision: acb3f4ac5424181d3d4d73283668162137918cf1 (2015-10-29)

Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=fc706d376f0658e560a59c3dd520437b18e8c4a4&tochange=acb3f4ac5424181d3d4d73283668162137918cf1

m-i:

Last good revision: c7d560f6e228adc9beeca962b1f9ed3682b4dc5d
First bad revision: cbe032ac35c235cbd9dbf7c7b2f13f60ead60a30

Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c7d560f6e228adc9beeca962b1f9ed3682b4dc5d&tochange=cbe032ac35c235cbd9dbf7c7b2f13f60ead60a30

Only bug related to this issue could be:
Bug 1212357 - Update the layout of the rooms list items for user journey

Comment 2

[Manuel Casas Barrado [:mancas]]

Attachment: Large favicon in hello panel for some websites

Mike could you review this minor css change? I set the favicon size to 16x16px.

Comment 3

[Manuel Casas Barrado [:mancas]]

Attachment: favicon.png

Comment 4

[Mike de Boer [:mikedeboer]]

Comment on attachment 8684194 [details] [diff] [review]
Large favicon in hello panel for some websites

Review of attachment 8684194 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, looks good to me. Thanks for fixing this.

As an aside: restraining the size to 16px would only need the 'width' attribute to be set, not necessarily together with 'height'. This will cause the image to scale proportionally. But since favicons are always perfect squares, this side-effect is not visible here.

Comment 5

[Manuel Casas Barrado [:mancas]]

Attachment: Large favicon in hello panel for some websites

Just removing not necessary css lines

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/73ea1e0038d7

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/73ea1e0038d7