1222168 - Severe BetterPrivacy add-on issue

Status: RESOLVED WORKSFORME

(Firefox :: Extension Compatibility, defect)

Description

[Ingo]

User Agent: Mozilla/5.0 (en-US) Gecko Firefox/20
Build ID: 20140314220517

Steps to reproduce:

While the BetterPrivacy (default) option 'Prevent the Firefox Clear History functions from handling LSOs as usual cookies' is enabled,
the native 'Clear cache' functions of FF 42 no longer work. BetterPrivacy needs to override the native Cookie handling for certain reasons and therefore uses a an override function as follows:

  handleSanitizeCookies: function (onShutdown, overrides) {
      try{
              if ( typeof Sanitizer !== 'function' ) {
                    Components.classes["@mozilla.org/moz/jssubscript-loader;1"]
                    .getService(Components.interfaces.mozIJSSubScriptLoader)
                    .loadSubScript("chrome://browser/content/sanitize.js", null);
              }
              var handleCookieClearing = bprivacy.shouldHandleCookieClearing (overrides) ;
              if ( handleCookieClearing ) {
                    var range = null;  // If we ignore timespan, clear everything
                    if (!Sanitizer.ignoreTimespan)
                            range = Sanitizer.range || Sanitizer.getClearRange();
                  try{
                      Sanitizer.prototype.items.cookies = undefined;
                  } catch(e) {}
                  Sanitizer.prototype.items.cookies =
                  {
                      clear : function () {
                          bprivacy.BPSanitizeCookies(range);
                      },
                      get canClear ()
                      {
                        return true;
                      }
                  }
            }


Actual results:

It seems this function no longer works due to a change in FF 42.


Expected results:

Any information related to the FF code of recent changes addressing this topic is helpful, especially information about the new location of code which is handling those special functions (omni.ja or elsewhere??) . Is it overridable??

Comment 1

[Gingerbread Man]

Note: reporter is the add-on author.
―――――

Notable changes of interest to add-on authors are listed in the developer release notes and in the Mozilla Add-ons Blog posts.
https://developer.mozilla.org/en-US/Firefox/Releases/42#Changes_for_add-on_and_Mozilla_developers
https://blog.mozilla.org/addons/2015/10/02/compatibility-for-firefox-42/

If you can't find the relevant change there, you can use the mozregression tool to narrow it down to a day's worth of patches.
http://mozilla.github.io/mozregression/

Comment 2

[Ingo]

Thanks Gingerbread Man,

it was my fault - meanwhile I found a second (and different!) version of omni.ja in the folder ...\browser\omni\chrome\browser\content\browser\ which really contains sanitize.js - the file I was looking for.

Thus I try to set this bug to resoloved-works for me as far as my rights here will allow to do so.

Have a nice day and thank you for your work, nice to see you (the man of millions helpful comments) are still alive...