Closed Bug 1222249 Opened 9 years ago Closed 9 years ago

Only listen to screen reader related events when it is enabled.

Categories

(Firefox OS Graveyard :: Gaia::System::Accessibility, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::Accessibility
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(feature-b2g:2.2r+, b2g-v2.2r fixed)

Status:
RESOLVED FIXED
Project Flags:
feature-b2g 2.2r+
Tracking Flags:
Tracking Status
b2g-v2.2r --- fixed

People

(Reporter: yzen, Assigned: yzen)

References

Details

(Keywords: access)

Attachments

(2 files)

[gaia] yzen:bug-1222249 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
djf
: review+
Details | Review
[gaia] yzen:bug-1222249-v2.2r > mozilla-b2g:v2.2r
46 bytes, text/x-github-pull-request
Details | Review
Right now we are always listening for: 'mozChromeEvent' 'appwillopen' 'appopened' 'homescreenopening' 'homescreenopened' We should only do that when screen reader is on.
Comment on attachment 8683939 [details] [review] [gaia] yzen:bug-1222249 > mozilla-b2g:master Making sure the events do get handled when the screen reader is disabled.
Attachment #8683939 - Flags: review?(timdream)
Comment on attachment 8683939 [details] [review] [gaia] yzen:bug-1222249 > mozilla-b2g:master David offered to review, moving the flag to him
Attachment #8683939 - Flags: review?(timdream) → review?(dflanagan)
blocking-b2g: --- → 2.2r?
Comment on attachment 8683939 [details] [review] [gaia] yzen:bug-1222249 > mozilla-b2g:master Simple patch. Looks good to me.
Attachment #8683939 - Flags: review?(dflanagan) → review+
https://github.com/mozilla-b2g/gaia/commit/ece3c9ad987d4cd310906fa218b3b0df07aec292
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Requesting for 2.2r PR
Keywords: checkin-needed
Comment on attachment 8683947 [details] [review] [gaia] yzen:bug-1222249-v2.2r > mozilla-b2g:v2.2r [Approval Request Comment] This bug aggravates the current issue with audio channels and causes bug 1222143 [Bug caused by] (feature/regressing bug #): 1209062 [User impact] if declined: audio channel issue will persist
Attachment #8683947 - Flags: approval-gaia-v2.2r?
Does this bug effect v2.5? We should probably uplift to there is so as well.
Flags: needinfo?(yzenevich)
(In reply to Michael Henretty [:mhenretty] from comment #9) > Does this bug effect v2.5? We should probably uplift to there is so as well. AFAIK, the offender PR was not uplifted.
Flags: needinfo?(yzenevich)
clearing checkin-needed flag since this needs approval still
Keywords: checkin-needed
blocking-b2g: 2.2r? → ---
feature-b2g: --- → 2.2r+
Attachment #8683947 - Flags: approval-gaia-v2.2r?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: