1222697 - [e10s] Audio Indicator doesn't appear when using Web Speech Synthesis

Status: RESOLVED FIXED

(Core :: Web Speech, defect, P1)

Description

[Makoto Kato [:m_kato]]

This is e10s only.  When turned on e10s, audio indicator doesn't appear.

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Create AudioChannelAgent on content process

Comment 2

[Makoto Kato [:m_kato]]

Humm, DisptachEnd will crash on try server....

Comment 3

[Jim Mathies [:jimm]]

Should this block e10s rollout?

Comment 4

[Makoto Kato [:m_kato]]

(In reply to Jim Mathies [:jimm] from comment #3)
> Should this block e10s rollout?

Yes.  Web Speech Synthesis API supports on 45+ as default, so we should support this since it works on non-e10s.

(But Chrome doesn't support it when using speech API :-<.)

Comment 5

[Makoto Kato [:m_kato]]

Of course, rollout is 45+, it should be blocker.  If not, it shouldn't.

Comment 6

[Simona Badau, Desktop QA]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:46.0) Gecko/20100101 Firefox/46.0
Build ID: 20160207004019

Reproducible also on the latest Aurora 46.0a2 (tested on Mac OS X 10.10, Ubuntu 12.04 and Windows 10) - Audio indicator is not displayed when using Web Speech Synthesis and e10s is enabled. Used the following demo: 
http://eeejay.github.io/webspeechdemos/

Comment 7

[Jim Mathies [:jimm]]

We're blocking on this, do you have time for it?

Comment 9

[Makoto Kato [:m_kato]]

Web Speech Synthesis API is still turned off release build, but I have a fix for this.

Comment 10

[Jim Mathies [:jimm]]

(In reply to Makoto Kato [:m_kato] from comment #9)
> Web Speech Synthesis API is still turned off release build, but I have a fix
> for this.

Oh, ok, I'll move this to our P1 post first rollout list.

Comment 11

[Makoto Kato [:m_kato]]

Attachment: MozReview Request: Bug 1222697 - Audio Indicator doesn't appear when using Web Speech Synthesis. r?eeejay

Create audio channel agent even if e10s.  Dispatch*Inner won't be called from
child process's SpeechSynthesisRequestChild, so it is created at Dispatch*Impl.

Review commit: https://reviewboard.mozilla.org/r/43371/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/43371/

Comment 12

[Eitan Isaacson [:eeejay]]

https://reviewboard.mozilla.org/r/43369/#review40563

Looks good. I tested, and muting the tab doesn't work, obviously. This is still a bit misleading. But I guess that is another bug.

Comment 13

[Eitan Isaacson [:eeejay]]

Comment on attachment 8736542 [details]
MozReview Request: Bug 1222697 - Audio Indicator doesn't appear when using Web Speech Synthesis. r?eeejay

https://reviewboard.mozilla.org/r/43371/#review40565

Comment 14

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5027257b611e

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5027257b611e