Make the Panorama deprecation warning more prominent

VERIFIED FIXED in Firefox 45

Status

VERIFIED FIXED
3 years ago
2 years ago

People

(Reporter: steffen.wilberg, Assigned: Gijs)

Tracking

Trunk
Firefox 45

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Please make the Panorama deprecation warning more prominent.

Philipp suggested a black-on-yellow bar in attachment 8683061 [details].
Instead, it is white on black, with a fade-in animation, at the bottom. That is too easy to overlook.
(Assignee)

Updated

3 years ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Users using other interfaces to Panorama like "Tab Groups Helper" do not get informed at all by the current mechanism.

Did you consider showing a permanent bar (for all tabs) above content if the user has tab groups and has not yet confirmed he knows about the deprecation?
(In reply to Stefan Fleiter (:sfleiter) from comment #1)
> Did you consider showing a permanent bar (for all tabs) above content if the
> user has tab groups and has not yet confirmed he knows about the deprecation?

That was already (also) implemented as part of bug 1221500. That is, that bug added both a one-off notification bar above all content (will go away after a restart or when you click the [x]), and one in tab groups.
> That was already (also) implemented as part of bug 1221500. That is, that
> bug added both a one-off notification bar above all content (will go away
> after a restart or when you click the [x]), and one in tab groups.

Thanks for pointing this out!
Have not ever seen this and did not manage to do so starting from a fresh profile.
Will report this in bug 1221500.
(In reply to Stefan Fleiter (:sfleiter) from comment #3)
> > That was already (also) implemented as part of bug 1221500. That is, that
> > bug added both a one-off notification bar above all content (will go away
> > after a restart or when you click the [x]), and one in tab groups.
> 
> Thanks for pointing this out!
> Have not ever seen this and did not manage to do so starting from a fresh
> profile.
> Will report this in bug 1221500.

You wouldn't see it on a fresh profile created after we added the warning. Only users upgrading with a profile that predates the warning will see it. You can set browser.migration.version to some value below 33 in about:config to see it again.

Please don't comment in bug 1221500 but file a new bug if you still don't see something when restarting Firefox on a profile that is using tab groups and with the pref mentioned earlier set low enough.
Created attachment 8688938 [details]
MozReview Request: Bug 1222786 - make tab groups removal warning in tab groups UI more prominent, r?jaws

Bug 1222786 - make tab groups removal warning in tab groups UI more prominent, r?jaws
Attachment #8688938 - Flags: review?(jaws)
(I nicked the colors from the OS X notification bar gradient.)
Comment on attachment 8688938 [details]
MozReview Request: Bug 1222786 - make tab groups removal warning in tab groups UI more prominent, r?jaws

https://reviewboard.mozilla.org/r/25457/#review23015

Should we move this to the top of the UI instead of at the bottom, as comment #0 points out?

::: browser/components/tabview/ui.js:1574
(Diff revision 1)
> +      .css({background: 'linear-gradient(#ffe13e, #ffc703) #ffc703', color: 'rgba(0,0,0,0.95)'})

Why set background-color when the background-image is opaque? You can remove the background-color from the background shorthand property.
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #7)
> Should we move this to the top of the UI instead of at the bottom, as
> comment #0 points out?
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #9)
> (In reply to Jared Wein [:jaws] (please needinfo? me) from comment #7)
> > Should we move this to the top of the UI instead of at the bottom, as
> > comment #0 points out?

Gah, I missed this part of your feedback somehow.

So, when I initially landed this it had a rough ride, because panorama's APIs depend on visual location of items, and so do its tests. The search field for panorama, for instance, is at the top, and the search output is at the bottom (and initially became invisible when I first landed the patch, causing test failures).

Because Philipp's mockup also has it at the bottom, and because of the tight dependencies of Panorama on its visual representation (if you look at what the HTML in that iframe looks like, with almost everything absolutely positioned, you will also see that changing something there without having it break or obscure anything else is... not easy...)....... I am inclined to leave it at the bottom. I think the color will be sufficient to draw attention to it. Let me know if you feel strongly about moving it to the top.
Flags: needinfo?(gijskruitbosch+bugs)
Understood, now doesn't seem like a good time to start improving how Panorama handles its layout ;)

Comment 12

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1e70dad32a8a
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox45: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Comment on attachment 8688938 [details]
MozReview Request: Bug 1222786 - make tab groups removal warning in tab groups UI more prominent, r?jaws

Approval Request Comment
[Feature/regressing bug #]: panorama removal warning
[User impact if declined]: the warning isn't particularly noticeable inside panorama
[Describe test coverage new/current, TreeHerder]: nope, CSS-only change.
[Risks and why]: very low. One line change that is completely restricted to this warning.
[String/UUID change made/needed]: no
Attachment #8688938 - Flags: approval-mozilla-aurora?
Requesting QE team to verify the fix whenever feasible.
status-firefox44: --- → affected
Flags: qe-verify+
Comment on attachment 8688938 [details]
MozReview Request: Bug 1222786 - make tab groups removal warning in tab groups UI more prominent, r?jaws

Making the warning more visible seems like a good idea. Aurora44+
Attachment #8688938 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 16

3 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/527f7615ef42
status-firefox44: affected → fixed
Confirming that the panorama removal warning in tab groups UI is now more prominent using Firefox 44.0b4, build ID: 20151228134903.
Verified on Windows 7 64bit, Windows 10 64bit, Mac OS X 10.11 and Ubuntu 12.04 x86.
Status: RESOLVED → VERIFIED
status-firefox44: fixed → verified
Flags: qe-verify+
QA Contact: cornel.ionce
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.