122282 - Import file dialog: files with .ldif/.txt/.tab extension are not listed when corresponding file types are specified.

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[ji]

Build: 01/28 linux build

On Improt file dialog, when specifying file types as .ldif/.txt/.tab, files with
these extensions in the directory are not listed on the window.

Steps to reproduce:
0. Have some files with .ldif/.txt/.tab extension in a directory that you can
access.
1. Launch ABook.
2. Selct File | Import.
3. Select Address Book and click on Next.
4. Select Text file and click on Next
5. Select the directory that holds the files with .ldif/.txt/.tab extension
6. Select .ldif as the file type, the file with .ldif in the directory is not
listed. Same problem when selecting .tab/.txt as the file type. It doesn't
happen when selecting .csv or All files as the file type. 

I don't see this on widnows build.

Comment 1

[Ninoschka Baca]

Marking nsbeta1 since I can't see any ldif,txt or csv files in the import dialog. 

Comment 2

[Hakon]

*** Bug 131690 has been marked as a duplicate of this bug. ***

Comment 3

[Ninoschka Baca]

*** Bug 139200 has been marked as a duplicate of this bug. ***

Comment 4

[Ninoschka Baca]

Workaround: Choose to see "All files" and then you should be able to see the files.

Comment 5

[Roland Lammel]

It seems that the seperator for file extensions should be ';' and not ','. (Just
to be consistent)

Also the extension-list is appearing twice for me (as opposed to only once in
the other filepicker dialogs where the filtering is working).

Comment 6

[Chris Young]

I get the same behavior when using Mozilla 1.0 (Build 2002052918) on Mandrake
Linux 8.2.  I can see .ldi files (and .csv files) but not .ldif files.  This
occurs with the Import and Export file selection dialogue.  Also, selecting Tab
Delimited does not show .txt files, even though that is listed as an option --
only .tab files are shown.

I also see the same thing as Roland... all the extensions are listed twice in
the drop-down menu where you select ldif, csv, tab, or all files.

Looks like Bug 144791 is a duplicate of this bug.

Comment 7

[Ninoschka Baca]

Marking nsbeta1 because this is totally confusing. Please fix this so that the
import dialog can display the import files on the system.

Comment 8

[Jeesun Cho]

*** Bug 158201 has been marked as a duplicate of this bug. ***

Comment 9

[Samir Gehani]

Mail triage team: nsbeta1-

Comment 10

[Philip K. Warren]

Taking ownership of bug.

Comment 11

[Philip K. Warren]

Attachment: Simple Fix

This fixes two issues in the code.

1) AppendFilter expects extensions to be separated by a semicolon and a space -
see http://lxr.mozilla.org/seamonkey/source/widget/public/nsIFilePicker.idl#69
. I have changed the code so it separates the extensions by spaces in two
places - import and export. This should fix both problems.
2) Remove the extensions from the addressbook.properties file because it causes
the extensions to show up twice for builds using the nsFilepicker.js file
picker (UNIX). See comment 5.

Comment 12

[Philip K. Warren]

*** Bug 152170 has been marked as a duplicate of this bug. ***

Comment 13

[(not reading, please use [e-mail] instead)]

thanks philip, and sorry for the delay.

let me try the patch out on win32, to verify that it works properly there, and 
then I'll quickly r/sr.

Comment 14

[(not reading, please use [e-mail] instead)]

Attachment: screen shot from win32

here's how win32 looks (for ab import) without the fix.

win32 works as is, but from pkw's comment, linux doesn't.

his patch now, and see if win32 still works.

Comment 15

[(not reading, please use [e-mail] instead)]

Attachment: screen shot after the patch

screen shot after the fix.

so my problem is that the change to addressBook.properties fixes a problem on
linux ("Remove the extensions from the addressbook.properties file because it
causes the extensions to show up twice for builds using the nsFilepicker.js
file
picker (UNIX") but causes a new one on win32 ("extensions not appearing")

this seems like a general problem that should happen with other users of
nsFilepicker.js, or a problem with the mailnews code that we shouldn't be
specifying the extensions like that.

I'd rather land part of this fix, and move the other part to a new bug.

Comment 16

[(not reading, please use [e-mail] instead)]

Attachment: pkw's patch, without the change to addressbook.properties

let's spin the addressbook.properties change off to another bug.

Comment 17

[(not reading, please use [e-mail] instead)]

Comment on attachment 113767 [details] [diff] [review]
pkw's patch, without the change to addressbook.properties

r/sr=sspitzer on this part of pkw's patch

Comment 18

[(not reading, please use [e-mail] instead)]

hoping asa will a= this change for 1.3 beta, but not a 1.3 beta blocker.

if not 1.3 beta, then 1.3 final for sure.

Comment 19

[Asa Dotzler [:asa]]

Comment on attachment 113767 [details] [diff] [review]
pkw's patch, without the change to addressbook.properties

Let's hold this till we open for 1.3final. Thanks.

Comment 20

[(not reading, please use [e-mail] instead)]

Comment on attachment 113767 [details] [diff] [review]
pkw's patch, without the change to addressbook.properties

asa says (over irc) a=asa for 1.3 final, but wait until the tree is ready for
1.3 final checkins.

Comment 21

[(not reading, please use [e-mail] instead)]

fixed.  thanks for the fix, philip.

I've spin off the issue in comment #15 into a new bug. 

see bug #192666