Closed Bug 1223333 Opened 8 years ago Closed 8 years ago

Detect libavcodec on OpenBSD

Categories

(Core :: Audio/Video: Playback, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: gaston, Assigned: jya)

References

Details

Attachments

(1 file)

In http://mxr.mozilla.org/mozilla-central/source/dom/media/platforms/ffmpeg/FFmpegRuntimeLinker.cpp#36 there's runtime detection for a systemwide ffmpeg/libavcodec.

On OpenBSD (right now in -current) systemwide ffmpeg installs libavcodec.so.22.2, but if nspr's PR_LoadLibrary() is used the proper version is used.

It comes from ffmpeg 20150909 so matches LIBAVCODEC_56 API.

I'll work on a patch, but it should be more or less 'if on OpenBSD, try to open libavcodec.so and consider its libavcodec 56 api'.

See for reference on so versionning on openbsd : https://bugzilla.mozilla.org/show_bug.cgi?id=650772 and previous occurences : https://bugzilla.mozilla.org/show_bug.cgi?id=687320, https://bugzilla.mozilla.org/show_bug.cgi?id=667325
Assignee: nobody → jyavenard
Bug 1205746 requires the basic of what fixes this bug would do, so blocking it.
Also uses portable way to dynamically open libraries.
Attachment #8686008 - Flags: review?(ajones)
Attachment #8686008 - Flags: review?(ajones) → review+
Blocks: 1214462
Is this patch ready to land?
Flags: needinfo?(jyavenard)
Priority: -- → P2
Flags: needinfo?(jyavenard)
https://hg.mozilla.org/mozilla-central/rev/2d24be34b7e2
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.