1223344 - Some tweaks to gDevTools.jsm to get Devtools working in SeaMonkey

Status: RESOLVED FIXED

(DevTools :: General, defect)

Comment 1

[Philip Chee]

Attachment: Patch v1.0 tweak gDevTools.jsm for SeaMonkey compat

Comment 2

[Philip Chee]

Attachment: Patch v1.1 tweak gDevTools.jsm for SeaMonkey compat

> -    let tabContainer = win.document.getElementById("tabbrowser-tabs");
> +    let tabContainer = win.gBrowser.tabContainer;
Devtools uses gBrowser.tabContainer 48 times getElementById("tabbrowser-tabs") 2 times.
SeaMonkey's tabbrowser has a tabContainer property, but has a different elementID for the "tabbrowser-tabs".

> -    let mp = doc.getElementById("menuWebDeveloperPopup");
>      let mps = doc.getElementById("menu_devtools_separator");
> -    mp.insertBefore(fragMenuItems, mps);
> +    if (mps)
> +      mps.parentNode.insertBefore(fragMenuItems, mps);

For historical reasons our menupopup is called "toolsPopup" which we don't want to change due to backward compatibility with addons. On the other hand you can avoid needing the menupopup by doing:

let foo = doc.getElementById("foo_separator");
foo.parentNode.insertBefore(bar, foo);

>            let tabContainer = win.gBrowser.tabContainer;
> -          let numPinnedTabs = tabContainer.tabbrowser._numPinnedTabs;
> +          let numPinnedTabs = win.gBrowser._numPinnedTabs || 0;

(1) gBrowser is the tabbrowser. So you use gBrowser to get the tabContainer, then use the tabContainer to get the tabbrowser. This makes no sense.
(2) SeaMonkey's tabbrowser doesn't have a _numPinnedTabs property so this ends up as undefined. We can coerce this to a number using ||0 . 

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0616fad56376&group_state=expanded
https://treeherder.mozilla.org/#/jobs?repo=try&revision=37e7d13f6855&group_state=expanded
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a6c0342c56d4&group_state=expanded

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8690912 [details] [diff] [review]
Patch v1.1 tweak gDevTools.jsm for SeaMonkey compat

Review of attachment 8690912 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/framework/gDevTools.jsm
@@ +1085,5 @@
>      mbs.appendChild(fragBroadcasters);
>  
> +    let amps = doc.getElementById("appmenu_devtools_separator");
> +    if (amps)
> +      amps.parentNode.insertBefore(fragAppMenuItems, amps);

Nit: DevTools style uses braces even with 1 line if blocks

@@ +1091,3 @@
>      let mps = doc.getElementById("menu_devtools_separator");
> +    if (mps)
> +      mps.parentNode.insertBefore(fragMenuItems, mps);

Nit: DevTools style uses braces even with 1 line if blocks

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e091924468af

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e091924468af