Closed Bug 1223417 Opened 9 years ago Closed 9 years ago

Avoid setTimeout in sync app integration tests

Categories

(Firefox OS Graveyard :: Sync, defect)

Product:
Firefox OS Graveyard
Component:
Sync
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
FxOS-S11 (13Nov)

People

(Reporter: mbdejong, Assigned: mbdejong)

References

Details

Attachments

(1 file)

[gaia] michielbdejong:1223417-avoid-timer-in-integrationtest > mozilla-b2g:master
46 bytes, text/x-github-pull-request
ferjm
: review+
Details | Review
Instead of checking for closeStub.called every 100ms [1], store the promise and resolve it from the closeStub. [1] https://github.com/mozilla-b2g/gaia/blob/master/apps/sync/test/unit/integration_test.js#L109
Assignee: nobody → mbdejong
Blocks: fxos-sync
Target Milestone: --- → FxOS-S11 (13Nov)
Attachment #8686013 - Flags: review?(ferjmoreno)
Attachment #8686013 - Flags: review?(ferjmoreno) → review+
https://github.com/mozilla-b2g/gaia/commit/2214078740a1944f63d1fd9e66338465f3c35eec
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: