1223421 - Hide/Obfuscate MozReview API Keys

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[Dylan Hardison [:dylan] (he/him)]

To avoid confusion, mozreview api keys should be readily usable on the api keys page.

Comment 1

[Dylan Hardison [:dylan] (he/him)]

Sigh. Comment #0 should say: To avoid confusion, mozreview api keys should NOT be readily usable on the api keys page

Comment 2

[:glob ✱]

Attachment: 1223421_1.patch

this has cropped up a few times over the last week causing much confusion, so here's a quick-n-dirty fix.

Comment 3

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8722333 [details] [diff] [review]
1223421_1.patch

Review of attachment 8722333 [details] [diff] [review]:
-----------------------------------------------------------------

Shouldn't rely on the description for this, I think. I have a fixed patch which I'll ask you to review :-)

Comment 4

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1223421_2.patch

Same as before except is_mozreview logic in the APIKey class.

Comment 5

[:glob ✱]

Comment on attachment 8722534 [details] [diff] [review]
1223421_2.patch

Review of attachment 8722534 [details] [diff] [review]:
-----------------------------------------------------------------

much better; r=glob

::: template/en/default/account/prefs/apikey.html.tmpl
@@ +46,5 @@
> +        [% END %]
> +      </td>
> +      <td>
> +        [% IF api_key.is_mozreview %]
> +          [% api_key.description FILTER html %]

perhaps it would be better to hard code "MozReview" as the visible description?

i only prevented renaming in my patch because i was using it to determine mozreview-ness.

Comment 6

[Dylan Hardison [:dylan] (he/him)]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   5eea1e0..110b14a  master -> master