122365 - Allow installation definable LDAP filters as a Parameter

Status: RESOLVED FIXED

(Bugzilla :: Administration, task, P3)

Description

[James A. Laska]

I wanted to restrict LDAP users to bugzilla.  Since most LDAP servers maintain a
wealth of info about it's users, I wanted to filter on some of that information.
 To this end, I have added a Parameter to defparams.pl called LDAPadditional. 
This parameter should conform to the string representation for search filters as
defined in RFC 2254 (http://www.faqs.org/rfcs/rfc2254.html).  When set, it is
AND'd with the Param("LDAPmailattribute") to come up with a search.  For
example, my variables are set as follows:

LDAPmailattribute = mail
LDAPadditional    = (|(dept=A)(dept=B))

The above would search for the user with mail equal to the given LDAPusername,
that is in either dept A OR dept B.

Code changes were the addition of a parameter in defparams.pl and filter code in
CGI.pl.  I have been using this for several weeks now and I haven't hit any
problems.  I will submit a patch following the bug submission.

Comment 1

[James A. Laska]

Attachment: Provide LDAPadditional parameter to allow for LDAP filtering

This patch affects: defparams.pl, CGI.pl

Comment 2

[James A. Laska]

Ooops, I have some extra stuff in the CGI.pl part of the patch.  Those fixes are
the result of an outstanding bug that no one has responded to (bug#105504). 
Sorry to sneak them in, adjust as you see fit.

Thanks!

Comment 3

[Bradley Baetz (:bbaetz)]

Mine - I have a patch

Comment 4

[Bradley Baetz (:bbaetz)]

Attachment: patch

Comment 5

[Dave Miller [:justdave]]

Comment on attachment 126894 [details] [diff] [review]
patch

tried this out on landfill.  It appears to work as advertised. :)

Comment 6

[Bradley Baetz (:bbaetz)]

Fixed.