1223684 - [Video]The "Cancel" button on the action menu does not appear as an oval button.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[Shally Li（leave from Mozilla）]

[1.Description]:
[Aries KK v2.5&2.6][Flame KK v2.5&2.6][Video]After tapping the " ..."  icon on the video playing page, the Cancel button does not appear as an oval button, but a rectangular button similar to other options in the menu.
Found at: 00:58
Attach: Flame_v2.6(video).png and logcat_0058.txt

[2.Testing Steps]: 
1. Launch Video.
2. Select a video to play.
3. Tap the " ..." icon at the right top.

[3.Expected Result]: 
3. The "Cancel" button should appear as an oval button.

[4.Actual Result]: 
3. The Cancel button will appear as a rectangular button similar to other options in the menu, with its text left-aligned and a blank space below it at the bottom of the screen.

[5.Reproduction build]: 
Device: Flame KK 2.2  512mb (unaffected) 
Build ID               20151110032503
Gaia Revision          885647d92208fb67574ced44004ab2f29d23cb45
Gaia Date              2015-10-07 13:05:24
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/ac5fce5a78e5
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151110.064719
Firmware Date          Tue Nov 10 06:47:30 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK 2.5  512mb (affected)
Build ID               20151109004552
Gaia Revision          cf646c52bb947af28329b0a100df91d1b1f2a907
Gaia Date              2015-11-09 02:55:50
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/4eafef5b80f8985c94c4a067f130d37513e1a581
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151109.041411
Firmware Date          Mon Nov  9 04:14:26 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK v2.6 512mb (master)(affected)
Build ID               20151110150205
Gaia Revision          c0482775b1526add626b170dd53a72d10bcaf07c
Gaia Date              2015-11-10 02:25:52
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cc473fe5dc512c450634506f68cbacfb40a06a23
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151110.182433
Firmware Date          Tue Nov 10 18:24:47 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (affected)
Build ID               20151110094357
Gaia Revision          07baf613699fa6225359c7f04825c5caeb71d424
Gaia Date              2015-11-09 21:32:50
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/e14287b00a514a15418dfaa89287030c588ad19d
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151110.090331
Firmware Date          Tue Nov 10 09:03:39 UTC 2015
Bootloader             s1

Device: Aries KK 2.6 (master)(affected)
Build ID               20151110120047
Gaia Revision          c0482775b1526add626b170dd53a72d10bcaf07c
Gaia Date              2015-11-10 02:25:52
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/cc473fe5dc512c450634506f68cbacfb40a06a23
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151110.111927
Firmware Date          Tue Nov 10 11:19:35 UTC 2015
Bootloader             s1


[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[Shally Li（leave from Mozilla）]

Attachment: Flame_v2.6(video).png

Comment 2

[Shally Li（leave from Mozilla）]

Attachment: logcat_0058.txt

Comment 3

[Shally Li（leave from Mozilla）]

Attachment: logcat_0058.txt

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1223675_video_menu_cancel_button > mozilla-b2g:master

Comment 6

[Kevin Grandon :kgrandon]

Comment on attachment 8686086 [details] [review]
[gaia] KevinGrandon:bug_1223675_video_menu_cancel_button > mozilla-b2g:master

David or Russ - could either of you review this patch? This ports the video menu to use a web component which renders perfectly here. This is needed due to a platform change which breaks CSS of the old building blocks. Thanks!

Comment 7

[Russ Nicoletti [:russn]]

Comment on attachment 8686086 [details] [review]
[gaia] KevinGrandon:bug_1223675_video_menu_cancel_button > mozilla-b2g:master

Looks good to me. One nit (unrelated to the patch) in the PR.

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 8686086 [details] [review]
[gaia] KevinGrandon:bug_1223675_video_menu_cancel_button > mozilla-b2g:master

Thanks a lot for the review Russ!

Comment 9

[Kevin Grandon :kgrandon]

Thanks for the review.

In master: https://github.com/mozilla-b2g/gaia/commit/98f63d4cc530906fa51d839a10469006c257b998

Comment 10

[Kevin Grandon :kgrandon]

[Blocking Requested - why for this release]: This should probably block for the same reason the parent bug blocks - UX regression.

Comment 11

[Kevin Grandon :kgrandon]

This is only removing some strings, but I guess it's late-l10n. If that causes a problem we can prepare a patch without the string removals, though I would prefer to uplift as-is.

Comment 12

[Francesco Lodolo [:flod]]

(In reply to Kevin Grandon :kgrandon from comment #11)
> If that causes a problem we can prepare a patch without the string removals, though
> I would prefer to uplift as-is.

A patch that doesn't touch strings is a lot cleaner on our side. Even removal means adding noise to repo and tools.

Comment 13

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.6 and Aires KK 2.6 by the STR in comment 0.

Actual results: The Cancel button is shown normally as an oval button.
See attachment: verified_Flame_v2.6.png
Reproduce rate: 0/10


Device: Flame KK v2.6 512mb (master)(Pass)
Build ID               20151112150206
Gaia Revision          27bc9412ca607648bc398b25bb1ae25653b2b278
Gaia Date              2015-11-12 02:27:47
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/3cc3b1968524248450c465c4ea2ee5596ffa65f2
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151112.183236
Firmware Date          Thu Nov 12 18:32:49 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.6 (master)(Pass)
Build ID               20151112120735
Gaia Revision          27bc9412ca607648bc398b25bb1ae25653b2b278
Gaia Date              2015-11-12 02:27:47
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/3cc3b1968524248450c465c4ea2ee5596ffa65f2
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151112.112635
Firmware Date          Thu Nov 12 11:26:43 UTC 2015
Bootloader             s1

Comment 14

[Shally Li（leave from Mozilla）]

Attachment: verified_Flame_v2.6.png

Comment 15

[Hema Koka [:hema]]

Visual regression. Please request for uplift approval similar to bug https://bugzilla.mozilla.org/show_bug.cgi?id=1222295

Comment 16

[Kevin Grandon :kgrandon]

Comment on attachment 8686086 [details] [review]
[gaia] KevinGrandon:bug_1223675_video_menu_cancel_button > mozilla-b2g:master

Will do, but I do think that these should be blockers!

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Platform regression requiring UI updates.
[User impact] if declined: Poor UX in menu.
[Testing completed]: Manual testing.
[Risk to taking this patch] (and alternatives if risky): Low risk, we're moving to a shared component.
[String changes made]: None.

Comment 17

[Delphine Lebédel [:delphine - Use needinfo]]

Kevin: I see that you suggest not touching strings in comment 11, and Flod replied on comment 12. However looking at your patch I believe it would still break string freeze on 2.5 as is. Is there any way we can avoid that at this point?

Comment 18

[Kevin Grandon :kgrandon]

Oops, it's easy enough to change the 2.5 patch to not remove the strings, but it feels sill to me. You guys should update your tools so this isn't a problem :)

I'll submit a patch for 2.5 now.

Comment 19

[Kevin Grandon :kgrandon]

Attachment: Pull request - uplift to 2.5

Here is a 2.5 specific patch with no string changes. Carrying review and requesting uplift on this.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Platform regression requiring UI updates.
[User impact] if declined: Poor UX in menu.
[Testing completed]: Manual testing.
[Risk to taking this patch] (and alternatives if risky): Low risk, we're moving to a shared component.
[String changes made]: None.

Comment 20

[Mahendra Potharaju [:mahe]]

Comment on attachment 8686086 [details] [review]
[gaia] KevinGrandon:bug_1223675_video_menu_cancel_button > mozilla-b2g:master

Approved for 2.5 uplift.

Thanks

Comment 21

[Mahendra Potharaju [:mahe]]

Comment on attachment 8689346 [details] [review]
Pull request - uplift to 2.5

Approved for 2.5 uplift

Thanks

Comment 22

[Pascal Chevrel:pascalc]

(In reply to Kevin Grandon :kgrandon from comment #18)
> Oops, it's easy enough to change the 2.5 patch to not remove the strings,
> but it feels sill to me. You guys should update your tools so this isn't a
> problem :)

Patches welcome ;) 
In the meantime, can you please update your patch to not break the string freeze please, thanks!

Comment 23

[Mahendra Potharaju [:mahe]]

Comment on attachment 8686086 [details] [review]
[gaia] KevinGrandon:bug_1223675_video_menu_cancel_button > mozilla-b2g:master

Removing approval for this patch as this has string changes. 

Approval set for the other patch.

Comment 24

[Kevin Grandon :kgrandon]

Uplifted stringless patch: https://github.com/mozilla-b2g/gaia/commit/5839f17dedc757947c9531dc0d66c3c49119f5ea

Comment 25

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: The Cancel button is shown normally as an oval button.
See above attachment: "verified_Flame_v2.6.png"
Reproduce rate: 0/10

Device: Flame 2.5 512mb (Pass) 
Build ID               20151123163948
Gaia Revision          5839f17dedc757947c9531dc0d66c3c49119f5ea
Gaia Date              2015-11-20 22:47:58
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/3a45ca93dd447e046baa2c7590f60ae008e438f8
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151123.155405
Firmware Date          Mon Nov 23 15:54:14 UTC 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK v2.5 (Pass)
Build ID               20151123164502
Gaia Revision          5839f17dedc757947c9531dc0d66c3c49119f5ea
Gaia Date              2015-11-20 22:47:58
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/3a45ca93dd447e046baa2c7590f60ae008e438f8
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151123.155500
Firmware Date          Mon Nov 23 15:55:07 UTC 2015
Bootloader             s1