Closed Bug 1224194 Opened 8 years ago Closed 8 years ago

Template string 'Last synced {{ when }}' visible in phone UI when syncing for the first time

Categories

(Firefox OS Graveyard :: Sync, defect, P3)

Product:
Firefox OS Graveyard
Component:
Sync
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
FxOS-S11 (13Nov)

People

(Reporter: mbdejong, Assigned: ferjm)

References

Details

Attachments

(1 file)

[gaia] ferjm:bug1224194.lastsync.hide > mozilla-b2g:master
46 bytes, text/x-github-pull-request
yzen
: review+
Details | Review 
      No description provided.
Should replace '{{ when }}' template placeholder with 'never' or similar rephrasing when no sync run has ever happened yet.
Blocks: fxos-sync
Target Milestone: --- → FxOS-S11 (13Nov)
Assignee: nobody → ferjmoreno
Priority: -- → P3
This should never be shown in theory [1]. How did you get to this state?

[1] https://mxr.mozilla.org/gaia/source/apps/settings/js/panels/firefox_sync/firefox_sync.js#285
Flags: needinfo?(mbdejong)
Can't replicate it now! Will reopen if/when I can. It might have been related to the network connectivity tests I was doing.
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(mbdejong)
Resolution: --- → WORKSFORME
I managed to reproduce it opening the settings panel right after device boot up.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Attachment #8690546 - Flags: review?(yzenevich)
Comment on attachment 8690546 [details] [review]
[gaia] ferjm:bug1224194.lastsync.hide > mozilla-b2g:master

Good stuff, thanks!
Attachment #8690546 - Flags: review?(yzenevich) → review+
https://github.com/mozilla-b2g/gaia/commit/9aeeb7faf186cd89cd59ad3d44161b20cbc4f05b
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.