1224204 - 'Get Started' button does nothing after a Server Unreachable error

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Sync, defect, P2)

Description

[Michiel de Jong [:michielbdejong]]

Afte a Server Unreachable error, you see an 'Oops! Something went wrong' alert. If you click that away, you see the page with the 'Get Started' button, but clicking on it does nothing.

Workaround: go back to main settings menu, and back into Sync settings. After this, the button does work.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] ferjm:bug1224204.getstarted.serverunreachable > mozilla-b2g:master

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

[Blocking Requested - why for this release]: This affects 2.5 TVs shipping Sync. The UX is pretty bad in this case. The user won't be able to enable Sync until the TV is restarted in case that the server is unreachable during the enabling step.

Comment 4

[Michiel de Jong [:michielbdejong]]

Comment on attachment 8688861 [details] [review]
[gaia] ferjm:bug1224204.getstarted.serverunreachable > mozilla-b2g:master

Ah, makes sense - only got to enabled if that's what we came from. Glad we caught this!

I do feel the state machine https://github.com/ferjm/gaia/blob/bug1224204.getstarted.serverunreachable/apps/system/js/sync_state_machine.js#L10-L24 is now a bit confusing - it doesn't clearly show that we changed the path:

 [disabled] -enable-> [enabled] -error-> [errored] -enable-> [enabled]

to:

 [disabled] -enable-> [enabled] -error-> [errored] -disable-> [disabled]

Maybe it would be cleaner to have separate 'enable-errored' and 'syncing-errored' states, but I think that's not a high priority.

Comment 5

[yifan [:yifan][:yliao]]

Comment on attachment 8688861 [details] [review]
[gaia] ferjm:bug1224204.getstarted.serverunreachable > mozilla-b2g:master

Thank you! And thank Michiel to noticte that the state machine diagram is a bit confusing now.

Comment 6

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/75eed2f5aec2d21957e7e0aad2431b97a1feb445