1224233 - crash in mozilla::IMEContentObserver::IMENotificationSender::Run when using on-screen (touch) keyboard on Windows 8+

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[:Gijs (out for now; he/him)]

This bug was filed from the Socorro interface and is 
report bp-7f85fadc-0419-44b0-9ed6-f79682151112.
=============================================================
STR:

1. open firefox on windows 8+
2. open about:config
3. filter for "ui.osk"
4. turn off keyboard detection
5. focus location bar / search bar in turn

ER:
you get an on-screen keyboard

AR:
you get an on-screen keyboard and Firefox crashes


Happens both with and without e10s

Olli had a suggestion about how to fix, testing now.

(this is an access violation non-nullptr crash, so hiding for now)

Comment 1

[:Gijs (out for now; he/him)]

Attachment: fix crashy usage of IMENotificationSender::Run using on-screen keyboard on Windows,

This was Olli's suggestion and it fixes the crash for me (and, having seen the suggestion, it makes sense to me why this would fix the crash, etc. etc.)

Comment 2

[:Gijs (out for now; he/him)]

This was a regression from bug 1218032 which only landed on central. That bug affects aurora, but aurora will be fixed by backing out other patches, so this only affects m-c and so per:

https://wiki.mozilla.org/Security/Bug_Approval_Process

I think I can just land this irrespective of what severity this would end up as.

Comment 3

[:Gijs (out for now; he/him)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f3ab1f50450a

Comment 5

[:Gijs (out for now; he/him)]

This was merged:

https://hg.mozilla.org/mozilla-central/rev/f3ab1f50450a

but missed today's nightly. Will be fixed in tomorrow's.