1224581 - Blocking and redirecting requests with onBeforeRequest doesn't work

Status: RESOLVED DUPLICATE of bug 1163862

(WebExtensions :: Untriaged, defect)

Description

[Maciej Ćwiek]

Attachment: test.xpi

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2490.80 Safari/537.36

Steps to reproduce:

1) Install the attached extension
2) Go to any page other than example.com


Actual results:

The requested page is loaded.


Expected results:

You should get redirected to example.com.

The same extension, when unpacked and loaded up in Chrome works as expected.

Comment 1

[Tobias B. Besemer [:BesTo] (QA)]

https://bugzilla.mozilla.org/show_bug.cgi?id=1066890#c11 -> Bill McCloskey (:billm)

Bill, can you confirm the bug and look to integrate it into the planing?

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

The .xpi file seems broken. It contains a manifest.json file and another xpi (which itself contains a manifest.json file). Can you upload the correct test add-on?

Comment 3

[Maciej Ćwiek]

Attachment: test-working.xpi

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Ah, I see. Right now we don't support redirection from onBeforeRequest. If you need a workaround, could you do the redirect from onBeforeSendHeaders instead?

Comment 5

[Maciej Ćwiek]

(In reply to Bill McCloskey (:billm) from comment #4)
> Ah, I see. Right now we don't support redirection from onBeforeRequest. If
> you need a workaround, could you do the redirect from onBeforeSendHeaders
> instead?

Since onBeforeSendHeaders also has request blocking capability, it could be an option for a workaround. We'll give it a try.

Comment 6

[Maciej Ćwiek]

(In reply to Bill McCloskey (:billm) from comment #4)
> Ah, I see. Right now we don't support redirection from onBeforeRequest. If
> you need a workaround, could you do the redirect from onBeforeSendHeaders
> instead?

I wasn't entirely right as in fact onBeforeSendHeaders is not able to redirect to a different URL.
However onHeadersReceived can, but there seems to be identical problem there as for onBeforeRequest - returning an object from the handler with redirectUrl property doesn't cause triggering the redirection. I've attached an xpi utilising onHeadersReceived, if you'd like to take a look.

Comment 7

[Maciej Ćwiek]

Attachment: test-onheadersreceived.xpi

Comment 8

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

(In reply to Maciej Ćwiek from comment #6)
> (In reply to Bill McCloskey (:billm) from comment #4)
> > Ah, I see. Right now we don't support redirection from onBeforeRequest. If
> > you need a workaround, could you do the redirect from onBeforeSendHeaders
> > instead?
> 
> I wasn't entirely right as in fact onBeforeSendHeaders is not able to
> redirect to a different URL.
> However onHeadersReceived can, but there seems to be identical problem there
> as for onBeforeRequest - returning an object from the handler with
> redirectUrl property doesn't cause triggering the redirection. I've attached
> an xpi utilising onHeadersReceived, if you'd like to take a look.

I'm not sure I understand what you mean here. It sounds like you need a single handler that can both block requests and redirect? If that's true, then there is no workaround. We'll need to wait until this bug is fixed.

Comment 9

[Markus Hartung]

What I can confirm is that in the onBeforeRequest a request can be canceled, curiously this doesn't seem to work when a search is initiated from the omnibar.

In onBeforeSendHeaders I was able to correctly redirect a request.

Comment 10

[Markus Hartung]

Would it be possible to have this available when e10s hits with version 46?

Comment 11

[Giorgio Maone [:ma1]]

(In reply to Markus Hartung from comment #10)
> Would it be possible to have this available when e10s hits with version 46?

My understanding is that current goal is enabling e10s for "50% of the population who do not have add-ons installed or a11y features enabled for Firefox 46", see https://wiki.mozilla.org/E10s/Status/Jan15#Release_Schedule

That said, I'm sure this will be available well before e10s gets enabled for add-ons users in stable Firefox releases.