1224813 - [TV][App Usage Metrics] "installs" in payload of app usage metric is not recorded when installing packaged app from Marketplace

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect, P1)

Description

[Cynthia Tang [:cynthiatang]]

+++ This bug was initially created as a clone of Bug #1218327 +++

If installing the packaged app from Marketplace, like Line/ Skate Jumper, we found that the installs is not count in payload. However, if we uninstall the app, the "uninstalls" will be count. This won't happen in hosted apps.

Steps:
 1. Modify the apps/system/js/app_usage_metrics.js and reset gaia
   AUM.REPORT_URL = 'https://incoming-telemetry-mozilla-org-koge918u861h.runscope.net/submit/telemetry';
   AUM.DEBUG = true;
   AUM.REPORT_INTERVAL = 60 * 1000;

 2. Search "Line" or "Skate Jumper" packaged app in Marketplace
 3. Install the app
 4. Wait for more than 1 minute until the data is sent
 5. Check the payload of appusage.

Actual result:
 - The payload of this app is shown in below. The installs is 0.
  "https://marketplace.firefox.com/app/7e382154-a942-4e45-ae0a-fc6d82be9a0f/manifest.webapp": {
      "20151111": {
      "usageTime": 4,
      "invocations": 1,
      "installs": 0,
      "uninstalls": 0,
      "enables": 0,
      "disables": 0,
      "activities": {},
      "addOn": false
    }
  },

Expected result:
 - The "installs" should be 1.

However, if the app is uninstalled, the "uninstalls" is 1.
  "https://marketplace.firefox.com/app/7e382154-a942-4e45-ae0a-fc6d82be9a0f/manifest.webapp": {
      "20151111": {
      "usageTime": 11,
      "invocations": 1,
      "installs": 0,
      "uninstalls": 1,
      "enables": 0,
      "disables": 0,
      "activities": {},
      "addOn": false
    }
  },

Comment 1

[Cynthia Tang [:cynthiatang]]

[Blocking Requested - why for this release]:

Comment 2

[Josh Cheng [:josh]]

Hi Luke, Hi Rex,
Can you have a first check? Thanks!

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] rexboy7:bug-1224813 > mozilla-b2g:master

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8688360 [details] [review]
[gaia] rexboy7:bug-1224813 > mozilla-b2g:master

This patch carries r+ from fabrice and marshall from bug 1218327.
I just applied the same patch to smart-system of TV.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Adding of feature for tracking addons
[User impact] if declined: We will not be able to track installs in AppUsage Metrics
[Testing completed]: Local testing completed.
[Risk to taking this patch] (and alternatives if risky):  Relatively low.  It's a rather small change isolated to the Telemetry files.  
[String changes made]: None.

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

master:
https://github.com/mozilla-b2g/gaia/commit/51e35d06ba49574fd223f5cc09310a4c2449abec

Comment 6

[Mahendra Potharaju [:mahe]]

Comment on attachment 8688360 [details] [review]
[gaia] rexboy7:bug-1224813 > mozilla-b2g:master

Approved for 2.5 uplift. 

Thanks

Comment 7

[Luke Chang [:lchang] (inactive)]

Cancel my NI since it's resolved.

Comment 8

[Carsten Book [:Tomcat]]

landed on 2.5 as https://github.com/mozilla-b2g/gaia/commit/57ed2d2825131c7ef3aa5fad2c72937d5d85ee67