Closed
Bug 1224818
Opened 9 years ago
Closed 9 years ago
Use the FX toolbarbutton-1 styling for TB
Categories
(Thunderbird :: Theme, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 45.0
People
(Reporter: Paenglab, Assigned: Paenglab)
Details
Attachments
(3 files, 2 obsolete files)
before.png
FX on Linux is not using the system toolbar button. This bug is to implement this styling in TB.
|
Assignee | |
Comment 1•9 years ago
|
||
Magnus, you are the only Linux reviewer I know, so I've chosen you.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8687556 -
Flags: review?(mkmelin+mozilla)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Added the part for Calendar I planned to land with a other patch (toolbarbutton-1 unify for Windows) which has to wait for other patches reviews. With this changes also the Event dialog is working as it should.
Attachment #8687556 -
Attachment is obsolete: true
Attachment #8687556 -
Flags: review?(mkmelin+mozilla)
Attachment #8687675 -
Flags: review?(mkmelin+mozilla)
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8687675 [details] [diff] [review] Linux-toolbarbuttons.patch Review of attachment 8687675 [details] [diff] [review]: ----------------------------------------------------------------- Looks ok to me. r=mkmelin
Attachment #8687675 -
Flags: review?(mkmelin+mozilla) → review+
|
|
||
Comment 5•9 years ago
|
||
Actually, I have to take that back. The buttons in the msg header have lost their padding
Keywords: checkin-needed
|
|
||
Updated•9 years ago
|
Attachment #8687675 -
Flags: review+ → review-
|
|
Assignee | |
Comment 6•9 years ago
|
||
I don't clearly understand what you mean. Please can you attach a screenshot with before/after? It could depend on different distributions or themes.
|
|
||
Comment 7•9 years ago
|
||
|
|
||
Comment 8•9 years ago
|
||
|
|
Assignee | |
Comment 9•9 years ago
|
||
This patch fixes the missing padding.
Attachment #8687675 -
Attachment is obsolete: true
Attachment #8689197 -
Flags: review?(mkmelin+mozilla)
|
|
||
Comment 10•9 years ago
|
||
Comment on attachment 8689197 [details] [diff] [review] Linux-toolbarbuttons.patch Review of attachment 8689197 [details] [diff] [review]: ----------------------------------------------------------------- Not sure I like the hard corners so much, but... r=mkmelin
Attachment #8689197 -
Flags: review?(mkmelin+mozilla) → review+
|
|
Assignee | |
Comment 11•9 years ago
|
||
They are not so hard, they have a radius of 2px. But yes, not easily visible. :)
Keywords: checkin-needed
|
|
||
Comment 12•9 years ago
|
||
https://hg.mozilla.org/comm-central/rev/79b18e6b5e34 -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 45.0
|
||
Comment 13•9 years ago
|
||
Comment on attachment 8689197 [details] [diff] [review] Linux-toolbarbuttons.patch >+++ b/calendar/base/content/dialogs/calendar-event-dialog.xul >@@ -54,16 +55,18 @@ > <script type="application/javascript" > src="chrome://global/content/globalOverlay.js"/> > <script type="application/javascript" > src="chrome://global/content/printUtils.js"/> > <script type="application/javascript" > src="chrome://calendar/content/calendar-statusbar.js"/> > <script type="application/javascript" > src="chrome://messenger/content/toolbarIconColor.js"/> >+ <script type="application/javascript" >+ src="chrome://messenger/content/toolbarIconColor.js"/> This seems strange, why is it being added a second time?
Flags: needinfo?(richard.marti)
|
|
Assignee | |
Comment 14•9 years ago
|
||
I must be blind then. :( I fix this in bug 1231822
Flags: needinfo?(richard.marti)
You need to log in
before you can comment on or make changes to this bug.
Description
•