1224844 - TEST-UNEXPECTED-FAIL | xpcshell-icaljs.ini:calendar/test/unit/test_gdata_provider.js | xpcshell return code: 0

Status: RESOLVED FIXED

(Calendar :: Provider: GData, defect)

Description

[Magnus Melin [:mkmelin]]

TEST-UNEXPECTED-FAIL | xpcshell-icaljs.ini:calendar/test/unit/test_gdata_provider.js | xpcshell return code: 0

Apparently perma failure atm (for the platforms running the tests).
http://archive.mozilla.org/pub/thunderbird/tinderbox-builds/comm-central-macosx64/1447499202/comm-central_snowleopard_test-xpcshell-bm107-tests1-macosx-build14.txt.gz

04:56:10     INFO -  TEST-START | xpcshell-icaljs.ini:calendar/test/unit/test_gdata_provider.js
04:56:11  WARNING -  TEST-UNEXPECTED-FAIL | xpcshell-icaljs.ini:calendar/test/unit/test_gdata_provider.js | xpcshell return code: 0
04:56:11     INFO -  TEST-INFO took 414ms
04:56:11     INFO -  >>>>>>>
04:56:11     INFO -  PROCESS | 5573 | Loading/builds/slave/test/build/application/Daily.app/Contents/Resources/extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/chrome.manifest
04:56:11     INFO -  PROCESS | 5573 | [calBackendLoader] Using icaljs backend at /builds/slave/test/build/application/Daily.app/Contents/Resources/extensions/{e2fda1a4-762b-4020-b5ad-a41df1933103}/components/icaljs-manifest
04:56:11     INFO -  PROCESS | 5573 | Loading/builds/slave/test/build/application/Daily.app/Contents/Resources/extensions/{a62ef8ec-5fdc-40c2-873c-223b8a6925cc}/chrome.manifest
04:56:11     INFO -  NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIXPCComponents_Utils.import]
04:56:11     INFO -  @/builds/slave/test/build/tests/xpcshell/tests/calendar/test/unit/test_gdata_provider.js:24:1
04:56:11     INFO -  load_file@/builds/slave/test/build/tests/xpcshell/head.js:606:7
04:56:11     INFO -  _load_files@/builds/slave/test/build/tests/xpcshell/head.js:618:3
04:56:11     INFO -  _execute_test@/builds/slave/test/build/tests/xpcshell/head.js:500:3
04:56:11     INFO -  @-e:1:1
04:56:11     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
04:56:11     INFO -  PROCESS | 5573 | JavaScript strict warning: /builds/slave/test/build/tests/xpcshell/tests/calendar/test/unit/test_gdata_provider.js, line 63: ReferenceError: reference to undefined property this.router
04:56:11     INFO -  PROCESS | 5573 | JavaScript error: /builds/slave/test/build/tests/xpcshell/tests/calendar/test/unit/test_gdata_provider.js, line 63: TypeError: this.router is undefined
04:56:11     INFO -  PROCESS | 5573 | JavaScript error: resource://calendar/modules/calUtils.jsm -> file:///builds/slave/test/build/application/Daily.app/Contents/Resources/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/calendar-js/calCalendarManager.js, line 63: NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "this.router is undefined" {file: "/builds/slave/test/build/tests/xpcshell/tests/calendar/test/unit/test_gdata_provider.js" line: 63}]'[JavaScript Error: "this.router is undefined" {file: "/builds/slave/test/build/tests/xpcshell/tests/calendar/test/unit/test_gdata_provider.js" line: 63}]' when calling method: [calIGenericOperationListener::onResult]
04:56:11     INFO -  NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "this.router is undefined" {file: "/builds/slave/test/build/tests/xpcshell/tests/calendar/test/unit/test_gdata_provider.js" line: 63}]'[JavaScript Error: "this.router is undefined" {file: "/builds/slave/test/build/tests/xpcshell/tests/calendar/test/unit/test_gdata_provider.js" line: 63}]' when calling method: [calIGenericOperationListener::onResult]
04:56:11     INFO -  "CONSOLE_MESSAGE: (info) Could not read chrome manifest 'file:///builds/slave/test/build/application/Daily.app/Contents/Resources/extensions/%7Ba62ef8ec-5fdc-40c2-873c-223b8a6925cc%7D/chrome.manifest'."
04:56:11     INFO -  "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property this.router" {file: "/builds/slave/test/build/tests/xpcshell/tests/calendar/test/unit/test_gdata_provider.js" line: 63}]"
04:56:11     INFO -  "CONSOLE_MESSAGE: (error) [JavaScript Error: "TypeError: this.router is undefined" {file: "/builds/slave/test/build/tests/xpcshell/tests/calendar/test/unit/test_gdata_provider.js" line: 63}]"
04:56:11     INFO -  "CONSOLE_MESSAGE: (error) [JavaScript Error: "NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "this.router is undefined" {file: "/builds/slave/test/build/tests/xpcshell/tests/calendar/test/unit/test_gdata_provider.js" line: 63}]'[JavaScript Error: "this.router is undefined" {file: "/builds/slave/test/build/tests/xpcshell/tests/calendar/test/unit/test_gdata_provider.js" line: 63}]' when calling method: [calIGenericOperationListener::onResult]" {file: "resource://calendar/modules/calUtils.jsm -> file:///builds/slave/test/build/application/Daily.app/Contents/Resources/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/calendar-js/calCalendarManager.js" line: 63}]"
04:56:11     INFO -  <<<<<<<

Comment 1

[[:MakeMyDay]]

This seems to affect Mac Opt tests only.

Comment 2

[Stefan Sitter [:ssitter]]

The first reported error is on this line in test_gdata_provider.js:
> Components.utils.import("resource://gdata-provider/modules/gdataSession.jsm");

Is it possible to see in the logs if gdata provider extension is installed and enabled at all?

Comment 3

[Wayne Mery (:wsmwk)]

it would be good to get this fixed for comm-beta

Comment 4

[Stefan Sitter [:ssitter]]

I have now seen the problem "ReferenceError: reference to undefined property this.router" sporadically on my local Windows build during xpcshell tests. My solution was to run 
> mach build calendar/providers/gdata/
and afterwards xpcshell tests pass. Maybe it depends if I did full build or only partial build, with or without clobber, ...?

Maybe there are differences with the build/packaging process on Mac OS X due to the handling of unified builds that causes gdata files being not in correct place when tests start.

Comment 5

[aleth [:aleth]]

(In reply to Stefan Sitter from comment #4)
> I have now seen the problem "ReferenceError: reference to undefined property
> this.router" sporadically on my local Windows build during xpcshell tests.
> My solution was to run 
> > mach build calendar/providers/gdata/
> and afterwards xpcshell tests pass. Maybe it depends if I did full build or
> only partial build, with or without clobber, ...?
> 
> Maybe there are differences with the build/packaging process on Mac OS X due
> to the handling of unified builds that causes gdata files being not in
> correct place when tests start.

Indeed, if this only happens on opt builds it could be fallout from bug 1224746.

Comment 6

[Stefan Sitter [:ssitter]]

Yes, failure is only reported for 'OS X 10.6 opt' and 'OS X 10.10 opt' builds. Corresponding 'debug' builds don't report the failure. Bug 1224844 and Bug 1224746 were reported almost the same day, indicating they might have the same cause.

Comment 7

[aleth [:aleth]]

(In reply to Stefan Sitter from comment #6)
> Yes, failure is only reported for 'OS X 10.6 opt' and 'OS X 10.10 opt'
> builds. Corresponding 'debug' builds don't report the failure. Bug 1224844
> and Bug 1224746 were reported almost the same day, indicating they might
> have the same cause.

The current patch from bug 1224746 packages calendar in make package-tests. But the xpcshell tests still fail, so something is still wrong.

Comment 8

[aleth [:aleth]]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=97539e5588f4

Comment 9

[aleth [:aleth]]

Attachment: Fix gdata test packaging for universal builds following bug 1201224

Comment 10

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 8696280 [details] [diff] [review]
Fix gdata test packaging for universal builds following bug 1201224

Review of attachment 8696280 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, r=philipp

Comment 11

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/4ac9d0bc8898cd89891478301f254ad46eff55aa
Bug 1224844 - Fix gdata test packaging for universal builds following bug 1201224. r=Fallen

Comment 12

[aleth [:aleth]]

Comment on attachment 8696280 [details] [diff] [review]
Fix gdata test packaging for universal builds following bug 1201224

Regression from mozilla 43.

Comment 13

[Stefan Sitter [:ssitter]]

Pushed to https://hg.mozilla.org/releases/comm-aurora/rev/d43bd90cff6c