Closed
Bug 1225073
Opened 10 years ago
Closed 10 years ago
Convert bookmark_test.js tests to Pinning
Categories
(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)
Firefox OS Graveyard
Gaia::System::Browser Chrome
ARM
Gonk (Firefox OS)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mikehenrty, Assigned: mikehenrty)
References
Details
(Whiteboard: [systemsfe])
Attachments
(1 file)
No description provided.
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8687897 [details] [review]
[gaia] mikehenrty:bug-1225073-bookmark-test > mozilla-b2g:master
Chris, I think this is the last of the bookmark tests for the new homescreen. Can you take a look?
Attachment #8687897 -
Flags: review?(chrislord.net)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → mhenretty
Comment 3•10 years ago
|
||
Comment on attachment 8687897 [details] [review]
[gaia] mikehenrty:bug-1225073-bookmark-test > mozilla-b2g:master
LGTM!
Attachment #8687897 -
Flags: review?(chrislord.net) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•10 years ago
|
||
Follow up to add back in client_options_bookmarks.js, which apparently some tests still use. Cwiiis gave me verbal r+ on IRC for it.
master: https://github.com/mozilla-b2g/gaia/commit/0d8289ab825eab62243fb964ab0345967578503c
You need to log in
before you can comment on or make changes to this bug.
Description
•