Closed Bug 1225073 Opened 9 years ago Closed 9 years ago

Convert bookmark_test.js tests to Pinning

Categories

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::System::Browser Chrome
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mikehenrty, Assigned: mikehenrty)

References

Details

(Whiteboard: [systemsfe])

Attachments

(1 file)

[gaia] mikehenrty:bug-1225073-bookmark-test > mozilla-b2g:master
46 bytes, text/x-github-pull-request
cwiiis
: review+
Details | Review 
      No description provided.
Comment on attachment 8687897 [details] [review]
[gaia] mikehenrty:bug-1225073-bookmark-test > mozilla-b2g:master

Chris, I think this is the last of the bookmark tests for the new homescreen. Can you take a look?
Attachment #8687897 - Flags: review?(chrislord.net)
Assignee: nobody → mhenretty
Comment on attachment 8687897 [details] [review]
[gaia] mikehenrty:bug-1225073-bookmark-test > mozilla-b2g:master

LGTM!
Attachment #8687897 - Flags: review?(chrislord.net) → review+
master: https://github.com/mozilla-b2g/gaia/commit/6d511c7d08b3fa579e85d6c354cf6f6ce6655980
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Follow up to add back in client_options_bookmarks.js, which apparently some tests still use. Cwiiis gave me verbal r+ on IRC for it.

master: https://github.com/mozilla-b2g/gaia/commit/0d8289ab825eab62243fb964ab0345967578503c
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: