Closed Bug 1225178 Opened 4 years ago Closed 4 years ago

Async scrollbars break list box & combo box scrolling

Categories

(Core :: Panning and Zooming, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: BenWa, Assigned: BenWa)

References

Details

Attachments

(1 file, 1 obsolete file)

Async scrollbars breaks list boxes and combo boxes scroll-bars (mouse wheel still works). I can reproduce this in bugzilla.
Attached patch patch (obsolete) — Splinter Review
Before I was trying GetDisplayPort with the PresShell. I recall trying with scrollabeContent but perhaps I didn't or messed something up. It is working indeed and the DisplayPort atom is only set from a test AFAIK. So everything is working as expected.

I also sneaked in a trivial check. It's triggered from the startup crash dialog which presumably is running under safe mode.

I don't plan on running this through try since it's behind a preference and unlikely to cause build failures.
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
Attachment #8692209 - Flags: review?(bugmail.mozilla)
Comment on attachment 8692209 [details] [diff] [review]
patch

Review of attachment 8692209 [details] [diff] [review]:
-----------------------------------------------------------------

There's a bunch of GL stuff in this patch that doesn't belong. r+ for the nsSliderFrame.cpp change, with a comment. Not sure if you intended to include the APZCTreeManager change or not, that seems unrelated. Let me know if that change was intentional, and if so, why.
Attachment #8692209 - Flags: review?(bugmail.mozilla) → review+
Ahh yes, that's a mistake. Thanks for overlooking it. I'll split it up before landing.
Attached patch patchSplinter Review
Attachment #8692209 - Attachment is obsolete: true
Attachment #8693026 - Flags: review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/1211fe850c050db6c21df7138a399039f67b77d7
Bug 1225178 - Don't start APZ drag if we don't have a displayport to handle it. r=kats
https://hg.mozilla.org/mozilla-central/rev/1211fe850c05
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.