1225178 - Async scrollbars break list box & combo box scrolling

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Benoit Girard (:BenWa)]

Async scrollbars breaks list boxes and combo boxes scroll-bars (mouse wheel still works). I can reproduce this in bugzilla.

Comment 1

[Benoit Girard (:BenWa)]

Attachment: patch

Before I was trying GetDisplayPort with the PresShell. I recall trying with scrollabeContent but perhaps I didn't or messed something up. It is working indeed and the DisplayPort atom is only set from a test AFAIK. So everything is working as expected.

I also sneaked in a trivial check. It's triggered from the startup crash dialog which presumably is running under safe mode.

I don't plan on running this through try since it's behind a preference and unlikely to cause build failures.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8692209 [details] [diff] [review]
patch

Review of attachment 8692209 [details] [diff] [review]:
-----------------------------------------------------------------

There's a bunch of GL stuff in this patch that doesn't belong. r+ for the nsSliderFrame.cpp change, with a comment. Not sure if you intended to include the APZCTreeManager change or not, that seems unrelated. Let me know if that change was intentional, and if so, why.

Comment 3

[Benoit Girard (:BenWa)]

Ahh yes, that's a mistake. Thanks for overlooking it. I'll split it up before landing.

Comment 4

[Benoit Girard (:BenWa)]

Attachment: patch

Comment 5

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1211fe850c050db6c21df7138a399039f67b77d7
Bug 1225178 - Don't start APZ drag if we don't have a displayport to handle it. r=kats

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1211fe850c05