1225221 - Accept 8k video in libvpx

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Ralph Giles (:rillian)]

Bug 1222145 raised the accepted video frame size to 8k. We also need to raise the corresponding internal limit for libvpx.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Part 1 - Bump frame limit in update.sh

Comment 2

[Ralph Giles (:rillian)]

Attachment: Part 2 - Bump frame limits in libvpx configs

Result of running the new update.sh script.

Comment 3

[Matthew Gregan [:kinetik]]

Comment on attachment 8688032 [details] [diff] [review]
Part 1 - Bump frame limit in update.sh

Review of attachment 8688032 [details] [diff] [review]:
-----------------------------------------------------------------

rs=kinetik

::: media/libvpx/update.py
@@ +398,4 @@
>          configure = ['../../configure', '--target=%s' % target,
>              '--disable-examples', '--disable-install-docs',
>              '--enable-multi-res-encoding',
> +            '--size-limit=8192x4608'

Wikipedia lists 10240x4320, 8192x5120, and 8192x8192.  Do we care about any of those?

Comment 4

[Matthew Gregan [:kinetik]]

Comment on attachment 8688033 [details] [diff] [review]
Part 2 - Bump frame limits in libvpx configs

Review of attachment 8688033 [details] [diff] [review]:
-----------------------------------------------------------------

rs=kinetik

Comment 5

[Ralph Giles (:rillian)]

(In reply to Matthew Gregan [:kinetik] from comment #3)

> Wikipedia lists 10240x4320, 8192x5120, and 8192x8192.  Do we care about any
> of those?

Not until someone requests them. Youtube is using 4320p. I just rounded up to 16:9 power-of-two because I like those better.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3c2ff433eb15
https://hg.mozilla.org/integration/mozilla-inbound/rev/567f820cb6e0

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3c2ff433eb15
https://hg.mozilla.org/mozilla-central/rev/567f820cb6e0