Closed Bug 1225221 Opened 4 years ago Closed 4 years ago

Accept 8k video in libvpx

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(2 files)

Bug 1222145 raised the accepted video frame size to 8k. We also need to raise the corresponding internal limit for libvpx.
Result of running the new update.sh script.
Attachment #8688033 - Flags: review?(kinetik)
Comment on attachment 8688032 [details] [diff] [review]
Part 1 - Bump frame limit in update.sh

Review of attachment 8688032 [details] [diff] [review]:
-----------------------------------------------------------------

rs=kinetik

::: media/libvpx/update.py
@@ +398,4 @@
>          configure = ['../../configure', '--target=%s' % target,
>              '--disable-examples', '--disable-install-docs',
>              '--enable-multi-res-encoding',
> +            '--size-limit=8192x4608'

Wikipedia lists 10240x4320, 8192x5120, and 8192x8192.  Do we care about any of those?
Attachment #8688032 - Flags: review?(kinetik) → review+
Comment on attachment 8688033 [details] [diff] [review]
Part 2 - Bump frame limits in libvpx configs

Review of attachment 8688033 [details] [diff] [review]:
-----------------------------------------------------------------

rs=kinetik
Attachment #8688033 - Flags: review?(kinetik) → review+
(In reply to Matthew Gregan [:kinetik] from comment #3)

> Wikipedia lists 10240x4320, 8192x5120, and 8192x8192.  Do we care about any
> of those?

Not until someone requests them. Youtube is using 4320p. I just rounded up to 16:9 power-of-two because I like those better.
https://hg.mozilla.org/mozilla-central/rev/3c2ff433eb15
https://hg.mozilla.org/mozilla-central/rev/567f820cb6e0
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
You need to log in before you can comment on or make changes to this bug.