1225224 - Prompt on clearing History when signed in to Sync

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Robin Andersen [:tecgirl]]

It's not immediately obvious to the user that choosing to enable 'Saved Logins' as a choice when clearing private data will wipe all instances of logins across their Fx account.

This option is defaulted to off, so when the user taps to enable it, provide a confirmation dialog with the following:

Are you sure?
This will remove all saved logins
from your Firefox account.
[Cancel][OK]

Cancel will keep the toggle in the off position, OK will enable it.

Comment 1

[Richard Newman [:rnewman]]

Is this a dupe of, sub-bug of, or split-out of Bug 1162778?

Comment 2

[Robin Andersen [:tecgirl]]

Bug 1162778 is a dialog for when the user Logs Out, which doesn't clear any data but stops syncing. This is for when Clearing Private Data. That dialog would provide them the option to go to the Clear Private Data view to do so.

Comment 3

[Richard Newman [:rnewman]]

(In reply to Robin Andersen [:tecgirl] from comment #2)
> Bug 1162778 is a dialog for when the user Logs Out, which doesn't clear any
> data but stops syncing. This is for when Clearing Private Data. That dialog
> would provide them the option to go to the Clear Private Data view to do so.

Ah, I'd morphed that bug to be both (because they're related), but I guess we can split and use this as one half.

Do you still want to give the user a pointer to sign out from FxA? That is, if the user got to this point, they might:

1. Intend to delete their passwords everywhere.
2. Have made a mistake and want to cancel.
3. Want to wipe this device but not their account -- they didn't think to go sign out first.

Comment 4

[Robin Andersen [:tecgirl]]

(In reply to Richard Newman [:rnewman] from comment #3)
> (In reply to Robin Andersen [:tecgirl] from comment #2)
> > Bug 1162778 is a dialog for when the user Logs Out, which doesn't clear any
> > data but stops syncing. This is for when Clearing Private Data. That dialog
> > would provide them the option to go to the Clear Private Data view to do so.
> 
> Ah, I'd morphed that bug to be both (because they're related), but I guess
> we can split and use this as one half.
> 
> Do you still want to give the user a pointer to sign out from FxA? That is,
> if the user got to this point, they might:
> 
> 1. Intend to delete their passwords everywhere.
> 2. Have made a mistake and want to cancel.
> 3. Want to wipe this device but not their account -- they didn't think to go
> sign out first.

The messaging on the Log Out dialog lets them know that the local data will remain, but will give the option to clear by going to Clear Private Data. So if they tap Log Out they'll see that and would have all the available choices listed above. I guess I should finish up that bug…

Comment 5

[Richard Newman [:rnewman]]

Note that we might fix the logins part by moving it into logins management, but we still need to prompt there.

Before prompting we should make sure that:

* The user has an account
* Either the account isn't functioning, or:
  * They have chosen to sync the affected data type.

Comment 6

[Richard Newman [:rnewman]]

Prompting on clearing logins will be handled in Bug 1226652 (bulk), Bug 1221709 (single).

Comment 7

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/1369

This patch shows a confirmation dialog when you Clear Private Data with History selected when logged in to Sync.

Comment 8

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8699583 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/1369

Adding a bunch of people just to make sure this gets attention sooner. Because if strings. Does not need 3 people review.

Comment 9

[Richard Newman [:rnewman]]

Comment on attachment 8699583 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/1369

r+ from me, ui+ from Robin, 'cos she came up with the strings in <https://github.com/mozilla/firefox-ios/commit/d5b0d469870a21249af7de9fb21fd62997336612>.

r+ with string updates, follow-up for conditional, and a couple nits.

Comment 10

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

All addressed. Followup files as bug 1233521