1224756 - Default "Saved Logins" to unchecked in Clear Private Data

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Richard Newman [:rnewman]]

This keeps biting users on both iOS and Android. Let's make sure it's not the default behavior.

Bug 1202810, Bug 1221290.

Comment 1

[Richard Newman [:rnewman]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/1261

Comment 2

[Emily Toop (:fluffyemily)]

Just wanted to check that this was the desired behaviour - if I select On for Saved Logins and then leave and then return, the toggle does not remember my previous choice and returns to Off. I can see why this might be the desired behaviour, but just in case...

Comment 3

[Emily Toop (:fluffyemily)]

Also, do we want some kind of dialog that would inform the user that enabling password clearing will remove all their passwords across their account?

Comment 4

[Aaron Train [:aaronmt]]

(In reply to Emily Toop (:fluffyemily) from comment #2)
> Just wanted to check that this was the desired behaviour - if I select On
> for Saved Logins and then leave and then return, the toggle does not
> remember my previous choice and returns to Off. I can see why this might be
> the desired behaviour, but just in case...

I filed this as bug https://bugzilla.mozilla.org/show_bug.cgi?id=1206730 and it was WONTFIXED.

Comment 5

[Richard Newman [:rnewman]]

(In reply to Emily Toop (:fluffyemily) from comment #2)
> Just wanted to check that this was the desired behaviour - if I select On
> for Saved Logins and then leave and then return, the toggle does not
> remember my previous choice and returns to Off. I can see why this might be
> the desired behaviour, but just in case...

It remembers your choice if you go through with the action (according to my testing). I assumed that's so users can get in a groove of clearing just their cookies.


(In reply to Emily Toop (:fluffyemily) from comment #3)
> Also, do we want some kind of dialog that would inform the user that
> enabling password clearing will remove all their passwords across their
> account?

Bug 1162778.

Comment 6

[Richard Newman [:rnewman]]

https://github.com/mozilla/firefox-ios/commit/b5a9b27276ec86ff1f6ba238b8c3d84cad71d2f6

Comment 7

[Robin Andersen [:tecgirl]]

(In reply to Emily Toop (:fluffyemily) from comment #3)
> Also, do we want some kind of dialog that would inform the user that
> enabling password clearing will remove all their passwords across their
> account?

Yes, since we now have this disabled by default and not immediately obvious what the action is, we should let the user know that logins/passwords will be cleared from all instances if they tap to enable it. This is related to Bug 1162778 but is a separate issue so I'll file a new one.