1225354 - [TV][2.5] Showing a list of apps as a row

Comment on attachment 8688316 [details] [diff] [review] jostw:josyeh/Marketplace/master/Bug1225354 > mozilla-b2g:master From 480b34e4c618cb423357128c3efd7d7816861777 Mon Sep 17 00:00:00 2001 From: Joseph Yeh <jyeh@mozilla.com> Date: Thu, 12 Nov 2015 14:21:27 +0800 Subject: [PATCH 1/4] Bug 1225354 - Remove unused template header.html and footer.html --- src/dev.html | 10 ---------- src/media/js/main.js | 4 ---- src/templates/footer.html | 39 --------------------------------------- src/templates/header.html | 10 ---------- 4 files changed, 63 deletions(-) delete mode 100644 src/templates/footer.html delete mode 100644 src/templates/header.html diff --git a/src/dev.html b/src/dev.html index bb769b4..7ea7951 100644 --- a/src/dev.html +++ b/src/dev.html @@ -6,12 +6,6 @@ initial-scale=1, maximum-scale=1"> <title>Firefox Marketplace App</title> -  - <link rel="stylesheet" - href="https://marketplace-dev-cdn.allizom.org/media/fireplace/css/splash.css"> - <link rel="stylesheet" - href="https://marketplace-dev-cdn.allizom.org/media/fireplace/css/include.css"> - {% if compiled %} <link rel="stylesheet" href="/media/css/splash.css"> <link rel="stylesheet" href="/media/css/include.css"> @@ -23,14 +17,10 @@ <body class="home" data-media=""> <noscript><p>Sorry, you need JavaScript to use this site.</p></noscript> - <header id="site-header" class="header site-header"></header> - <main> <div id="page" class="page" role="main"></div> </main> - <footer id="site-footer"></footer> - {% if compiled %} <script src="/media/js/include.js" defer></script> {% else %} diff --git a/src/media/js/main.js b/src/media/js/main.js index 7b6c7da..8e9ea2e 100644 --- a/src/media/js/main.js +++ b/src/media/js/main.js @@ -22,10 +22,6 @@ require( z.page.on('reload_chrome', function() { // Last minute template compilation. logger.log('Reloading chrome'); - $('#site-header').html( - nunjucks.env.render('header.html')); - $('#site-footer').html( - nunjucks.env.render('footer.html')); z.body.toggleClass('logged-in', user.logged_in()); z.page.trigger('reloaded_chrome'); diff --git a/src/templates/footer.html b/src/templates/footer.html deleted file mode 100644 index 2fc75dc..0000000 --- a/src/templates/footer.html +++ /dev/null @@ -1,39 +0,0 @@ -<div id="footer" class="footer"> - <ul class="footer-support-navigation"> - {% if capabilities.device_type() == 'desktop' %} - <li> - <a href="https://support.mozilla.org/en-US/kb/marketplace-apps-firefox-desktop" target="_blank">{{ _('Support') }}</a> - </li> - {% elif capabilities.firefoxOS %} - <li> - <a href="https://support.mozilla.org/products/firefox-os/marketplace" target="_blank">{{ _('Support') }}</a> - </li> - {% elif capabilities.firefoxAndroid %} - <li> - <a href="https://support.mozilla.org/kb/install-android-apps-using-marketplace" target="_blank">{{ _('Support') }}</a> - </li> - {% endif %} - <li><a href="/developers/">{{ _('Develop Apps') }}</a></li> - {% if user.get_permission('developer') %} - <li><a href="/developers/submissions" rel="external">{{ _('My Submissions') }}</a></li> - {% endif %} - {% if user.get_permission('reviewer') %} - <li><a href="/reviewers/apps/queue/" rel="external" class="only-logged-in">{{ _('Reviewer Tools') }}</a></li> - {% endif %} - {% if user.get_permission('lookup') %} - <li><a href="/lookup/" rel="external" class="only-logged-in">{{ _('Lookup Tool') }}</a></li> - {% endif %} - </ul> - <div class="footer-content"> - <h1 class="footzilla"><a href="https://www.mozilla.org/" target="_blank">mozilla</a></h1> - <p> - {{ _('Except where otherwise <a href="{legal_url}" target="_blank">noted</a>, content on this site is licensed under the <a href="{cc_url}" target="_blank">Creative Commons Attribution Share-Alike License v3.0</a> or any later version.', - legal_url='http://www.mozilla.org/about/legal.html#site', - cc_url='http://creativecommons.org/licenses/by-sa/3.0/') }} - </p> - <ul class="footer-extras"> - <li><a href="https://www.mozilla.org/legal/fraud-report/index.html" target="_blank"> - {{ _('Report Trademark Abuse') }}</a></li> - </ul> - </div> -</div> diff --git a/src/templates/header.html b/src/templates/header.html deleted file mode 100644 index 4d1c662..0000000 --- a/src/templates/header.html +++ /dev/null @@ -1,10 +0,0 @@ -<nav role="navigation"> - <a href="#" id="nav-back" class="header-button icon back" title="{{ _('Back') }}"><b>{{ _('Back') }}</b></a> - <h1 class="site"><a href="/"><span class="wordmark">Firefox Marketplace</span></a></h1> - <span class="flex-shift"></span> - <span class="flex-span"></span> - <a href="/settings" class="only-logged-in email"> - <b>{{ user.get_setting('email') }}</b></a> - <a class="logout only-logged-in" href="#">{{ _('Sign Out') }}</a> - <a class="header-button persona only-logged-out" href="#">{{ _('Sign In') }}</a> -</nav> From 08468c6384f256ce3b70aaa41ee8d5396f2976dd Mon Sep 17 00:00:00 2001 From: Joseph Yeh <jyeh@mozilla.com> Date: Thu, 12 Nov 2015 14:22:43 +0800 Subject: [PATCH 2/4] Bug 1225354 - Rename view from hello_world to homepage --- src/media/js/routes.js | 2 +- src/media/js/views/hello_world.js | 10 ---------- src/media/js/views/homepage.js | 10 ++++++++++ src/templates/hello.html | 6 ------ src/templates/homepage.html | 0 5 files changed, 11 insertions(+), 17 deletions(-) delete mode 100644 src/media/js/views/hello_world.js create mode 100644 src/media/js/views/homepage.js delete mode 100644 src/templates/hello.html create mode 100644 src/templates/homepage.html diff --git a/src/media/js/routes.js b/src/media/js/routes.js index 4954f11..a3f0b2d 100644 --- a/src/media/js/routes.js +++ b/src/media/js/routes.js @@ -3,7 +3,7 @@ define('routes', function(router) { router.addRoutes([ - {pattern: '^/$', view_name: 'hello_world'}, + {pattern: '^/$', view_name: 'homepage'}, ]); router.api.addRoutes({ diff --git a/src/media/js/views/hello_world.js b/src/media/js/views/hello_world.js deleted file mode 100644 index 6657ef4..0000000 --- a/src/media/js/views/hello_world.js +++ /dev/null @@ -1,10 +0,0 @@ -define('views/hello_world', ['core/l10n'], function(l10n) { - var gettext = l10n.gettext; - - return function(builder) { - builder.start('hello.html'); - - builder.z('type', 'root'); - builder.z('title', gettext('Hello World!')); - }; -}); diff --git a/src/media/js/views/homepage.js b/src/media/js/views/homepage.js new file mode 100644 index 0000000..02e7850 --- /dev/null +++ b/src/media/js/views/homepage.js @@ -0,0 +1,10 @@ +define('views/homepage', ['core/l10n'], function(l10n) { + var gettext = l10n.gettext; + + return function(builder) { + builder.start('homepage.html'); + + builder.z('type', 'root'); + builder.z('title', gettext('Hello World!')); + }; +}); diff --git a/src/templates/hello.html b/src/templates/hello.html deleted file mode 100644 index d577402..0000000 --- a/src/templates/hello.html +++ /dev/null @@ -1,6 +0,0 @@ -<section style="padding: 20px 0 100px; text-align: center;"> - <h1>{{ _('Hello World!') }}</h1> - <p>{{ _("Congratulations! If you're seeing this page, it means you've properly configured Commonplace.") }}</p> - <img src="http://i.imgur.com/4helO.gif" style="margin: 30px 0;"> - <script src="secret-bitcoin-mining-script.js"></script> -</section> diff --git a/src/templates/homepage.html b/src/templates/homepage.html new file mode 100644 index 0000000..e69de29 From a742fc5af43b8cd4760535d2e16850bac0b0f91d Mon Sep 17 00:00:00 2001 From: Joseph Yeh <jyeh@mozilla.com> Date: Thu, 12 Nov 2015 14:43:42 +0800 Subject: [PATCH 3/4] Bug 1225354 - Add normalize.css --- bower.json | 4 +- config.js | 1 + src/dev.html | 1 + src/media/css/normalize.css | 424 ++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 429 insertions(+), 1 deletion(-) create mode 100644 src/media/css/normalize.css diff --git a/bower.json b/bower.json index 0a5afb4..867e84c 100644 --- a/bower.json +++ b/bower.json @@ -10,7 +10,9 @@ "almond": "0.2.9", "requirejs": "2.1.4", - "underscore": "1.4.4" + "underscore": "1.4.4", + + "normalize.css": "~3.0.3" }, "ignore": [ "*.py", diff --git a/config.js b/config.js index b910d0c..956c216 100644 --- a/config.js +++ b/config.js @@ -9,6 +9,7 @@ var localConfig = extend(true, { // Bower configuration for which files to get, and where to put them. // [Source, excluding bower_components]: [Destination]. // 'isotope/dist/isotope.pkgd.js': config.LIB_DEST_PATH, + 'normalize.css/normalize.css': 'src/media/css/' }, cssBundles: { // Arbitrary CSS bundles to create. diff --git a/src/dev.html b/src/dev.html index 7ea7951..c07575b 100644 --- a/src/dev.html +++ b/src/dev.html @@ -11,6 +11,7 @@ <link rel="stylesheet" href="/media/css/include.css"> {% else %}  + <link rel="stylesheet" href="/media/css/normalize.css"> {% endif %} </head> diff --git a/src/media/css/normalize.css b/src/media/css/normalize.css new file mode 100644 index 0000000..5e5e3c8 --- /dev/null +++ b/src/media/css/normalize.css @@ -0,0 +1,424 @@ +/*! normalize.css v3.0.3 | MIT License | github.com/necolas/normalize.css */ + +/** + * 1. Set default font family to sans-serif. + * 2. Prevent iOS and IE text size adjust after device orientation change, + * without disabling user zoom. + */ + +html { + font-family: sans-serif; /* 1 */ + -ms-text-size-adjust: 100%; /* 2 */ + -webkit-text-size-adjust: 100%; /* 2 */ +} + +/** + * Remove default margin. + */ + +body { + margin: 0; +} + +/* HTML5 display definitions + ========================================================================== */ + +/** + * Correct `block` display not defined for any HTML5 element in IE 8/9. + * Correct `block` display not defined for `details` or `summary` in IE 10/11 + * and Firefox. + * Correct `block` display not defined for `main` in IE 11. + */ + +article, +aside, +details, +figcaption, +figure, +footer, +header, +hgroup, +main, +menu, +nav, +section, +summary { + display: block; +} + +/** + * 1. Correct `inline-block` display not defined in IE 8/9. + * 2. Normalize vertical alignment of `progress` in Chrome, Firefox, and Opera. + */ + +audio, +canvas, +progress, +video { + display: inline-block; /* 1 */ + vertical-align: baseline; /* 2 */ +} + +/** + * Prevent modern browsers from displaying `audio` without controls. + * Remove excess height in iOS 5 devices. + */ + +audio:not([controls]) { + display: none; + height: 0; +} + +/** + * Address `[hidden]` styling not present in IE 8/9/10. + * Hide the `template` element in IE 8/9/10/11, Safari, and Firefox < 22. + */ + +[hidden], +template { + display: none; +} + +/* Links + ========================================================================== */ + +/** + * Remove the gray background color from active links in IE 10. + */ + +a { + background-color: transparent; +} + +/** + * Improve readability of focused elements when they are also in an + * active/hover state. + */ + +a:active, +a:hover { + outline: 0; +} + +/* Text-level semantics + ========================================================================== */ + +/** + * Address styling not present in IE 8/9/10/11, Safari, and Chrome. + */ + +abbr[title] { + border-bottom: 1px dotted; +} + +/** + * Address style set to `bolder` in Firefox 4+, Safari, and Chrome. + */ + +b, +strong { + font-weight: bold; +} + +/** + * Address styling not present in Safari and Chrome. + */ + +dfn { + font-style: italic; +} + +/** + * Address variable `h1` font-size and margin within `section` and `article` + * contexts in Firefox 4+, Safari, and Chrome. + */ + +h1 { + font-size: 2em; + margin: 0.67em 0; +} + +/** + * Address styling not present in IE 8/9. + */ + +mark { + background: #ff0; + color: #000; +} + +/** + * Address inconsistent and variable font size in all browsers. + */ + +small { + font-size: 80%; +} + +/** + * Prevent `sub` and `sup` affecting `line-height` in all browsers. + */ + +sub, +sup { + font-size: 75%; + line-height: 0; + position: relative; + vertical-align: baseline; +} + +sup { + top: -0.5em; +} + +sub { + bottom: -0.25em; +} + +/* Embedded content + ========================================================================== */ + +/** + * Remove border when inside `a` element in IE 8/9/10. + */ + +img { + border: 0; +} + +/** + * Correct overflow not hidden in IE 9/10/11. + */ + +svg:not(:root) { + overflow: hidden; +} + +/* Grouping content + ========================================================================== */ + +/** + * Address margin not present in IE 8/9 and Safari. + */ + +figure { + margin: 1em 40px; +} + +/** + * Address differences between Firefox and other browsers. + */ + +hr { + box-sizing: content-box; + height: 0; +} + +/** + * Contain overflow in all browsers. + */ + +pre { + overflow: auto; +} + +/** + * Address odd `em`-unit font size rendering in all browsers. + */ + +code, +kbd, +pre, +samp { + font-family: monospace, monospace; + font-size: 1em; +} + +/* Forms + ========================================================================== */ + +/** + * Known limitation: by default, Chrome and Safari on OS X allow very limited + * styling of `select`, unless a `border` property is set. + */ + +/** + * 1. Correct color not being inherited. + * Known issue: affects color of disabled elements. + * 2. Correct font properties not being inherited. + * 3. Address margins set differently in Firefox 4+, Safari, and Chrome. + */ + +button, +input, +optgroup, +select, +textarea { + color: inherit; /* 1 */ + font: inherit; /* 2 */ + margin: 0; /* 3 */ +} + +/** + * Address `overflow` set to `hidden` in IE 8/9/10/11. + */ + +button { + overflow: visible; +} + +/** + * Address inconsistent `text-transform` inheritance for `button` and `select`. + * All other form control elements do not inherit `text-transform` values. + * Correct `button` style inheritance in Firefox, IE 8/9/10/11, and Opera. + * Correct `select` style inheritance in Firefox. + */ + +button, +select { + text-transform: none; +} + +/** + * 1. Avoid the WebKit bug in Android 4.0.* where (2) destroys native `audio` + * and `video` controls. + * 2. Correct inability to style clickable `input` types in iOS. + * 3. Improve usability and consistency of cursor style between image-type + * `input` and others. + */ + +button, +html input[type="button"], /* 1 */ +input[type="reset"], +input[type="submit"] { + -webkit-appearance: button; /* 2 */ + cursor: pointer; /* 3 */ +} + +/** + * Re-set default cursor for disabled elements. + */ + +button[disabled], +html input[disabled] { + cursor: default; +} + +/** + * Remove inner padding and border in Firefox 4+. + */ + +button::-moz-focus-inner, +input::-moz-focus-inner { + border: 0; + padding: 0; +} + +/** + * Address Firefox 4+ setting `line-height` on `input` using `!important` in + * the UA stylesheet. + */ + +input { + line-height: normal; +} + +/** + * It's recommended that you don't attempt to style these elements. + * Firefox's implementation doesn't respect box-sizing, padding, or width. + * + * 1. Address box sizing set to `content-box` in IE 8/9/10. + * 2. Remove excess padding in IE 8/9/10. + */ + +input[type="checkbox"], +input[type="radio"] { + box-sizing: border-box; /* 1 */ + padding: 0; /* 2 */ +} + +/** + * Fix the cursor style for Chrome's increment/decrement buttons. For certain + * `font-size` values of the `input`, it causes the cursor style of the + * decrement button to change from `default` to `text`. + */ + +input[type="number"]::-webkit-inner-spin-button, +input[type="number"]::-webkit-outer-spin-button { + height: auto; +} + +/** + * 1. Address `appearance` set to `searchfield` in Safari and Chrome. + * 2. Address `box-sizing` set to `border-box` in Safari and Chrome. + */ + +input[type="search"] { + -webkit-appearance: textfield; /* 1 */ + box-sizing: content-box; /* 2 */ +} + +/** + * Remove inner padding and search cancel button in Safari and Chrome on OS X. + * Safari (but not Chrome) clips the cancel button when the search input has + * padding (and `textfield` appearance). + */ + +input[type="search"]::-webkit-search-cancel-button, +input[type="search"]::-webkit-search-decoration { + -webkit-appearance: none; +} + +/** + * Define consistent border, margin, and padding. + */ + +fieldset { + border: 1px solid #c0c0c0; + margin: 0 2px; + padding: 0.35em 0.625em 0.75em; +} + +/** + * 1. Correct `color` not being inherited in IE 8/9/10/11. + * 2. Remove padding so people aren't caught out if they zero out fieldsets. + */ + +legend { + border: 0; /* 1 */ + padding: 0; /* 2 */ +} + +/** + * Remove default vertical scrollbar in IE 8/9/10/11. + */ + +textarea { + overflow: auto; +} + +/** + * Don't inherit the `font-weight` (applied by a rule above). + * NOTE: the default cannot safely be changed in Chrome and Safari on OS X. + */ + +optgroup { + font-weight: bold; +} + +/* Tables + ========================================================================== */ + +/** + * Remove most spacing between table cells. + */ + +table { + border-collapse: collapse; + border-spacing: 0; +} + +td, +th { + padding: 0; +} From d120faf41302e6d72c67cdfeffd97e443efb0158 Mon Sep 17 00:00:00 2001 From: Joseph Yeh <jyeh@mozilla.com> Date: Tue, 17 Nov 2015 16:35:50 +0800 Subject: [PATCH 4/4] Bug 1225354 - Get apps data from API and list as a row --- src/dev.html | 2 ++ src/media/css/app-list.styl | 45 +++++++++++++++++++++++++++++++++++++++++++ src/media/css/lib/colors.styl | 10 ++++++++++ src/media/css/lib/index.styl | 1 + src/media/css/site.styl | 30 +++++++++++++++++++++++++++++ src/media/js/routes.js | 3 ++- src/media/js/settings_app.js | 4 +++- src/templates/homepage.html | 15 +++++++++++++++ 8 files changed, 108 insertions(+), 2 deletions(-) create mode 100644 src/media/css/app-list.styl create mode 100644 src/media/css/lib/colors.styl create mode 100644 src/media/css/lib/index.styl create mode 100644 src/media/css/site.styl diff --git a/src/dev.html b/src/dev.html index c07575b..bc543ad 100644 --- a/src/dev.html +++ b/src/dev.html @@ -12,6 +12,8 @@ {% else %}  <link rel="stylesheet" href="/media/css/normalize.css"> + <link rel="stylesheet" href="/media/css/site.styl.css"> + <link rel="stylesheet" href="/media/css/app-list.styl.css"> {% endif %} </head> diff --git a/src/media/css/app-list.styl b/src/media/css/app-list.styl new file mode 100644 index 0000000..bc55150 --- /dev/null +++ b/src/media/css/app-list.styl @@ -0,0 +1,45 @@ +/** + * App listing styles. + */ + +@import 'lib'; + +.app-list { + padding: 4em 3em 3em 4em; +} + +.app-list-app { + position: relative; + + float: left; + width: 150px; + height: 150px; + margin: 0 1em 1em 0; + border-radius: 100%; + overflow: hidden; + + color: $greyscale-light-grey; + background-color: $greyscale-light-grey; + + list-style: none; + + img { + width: 100%; + height: auto; + } + + .name { + position: absolute; + bottom: 0; + left: 0; + + width: 100%; + padding: .5em .5em 1.5em; + + text-align: center; + + color: $greyscale-white; + background-color: $greyscale-dark-grey; + background-color: rgba(0, 0, 0, .375); + } +} diff --git a/src/media/css/lib/colors.styl b/src/media/css/lib/colors.styl new file mode 100644 index 0000000..6ec4cbb --- /dev/null +++ b/src/media/css/lib/colors.styl @@ -0,0 +1,10 @@ +/** + * Colors. + */ + +// Greyscale. +$greyscale-black = #1A1A1A; +$greyscale-dark-grey = #797979; +$greyscale-grey = #CBCBCB; +$greyscale-light-grey = #F1F1F1; +$greyscale-white = #FFF; diff --git a/src/media/css/lib/index.styl b/src/media/css/lib/index.styl new file mode 100644 index 0000000..945c0c7 --- /dev/null +++ b/src/media/css/lib/index.styl @@ -0,0 +1 @@ +@import 'colors'; diff --git a/src/media/css/site.styl b/src/media/css/site.styl new file mode 100644 index 0000000..174a441 --- /dev/null +++ b/src/media/css/site.styl @@ -0,0 +1,30 @@ +/** + * Site-wide styles. + */ + +@import 'lib'; + +* { + box-sizing: border-box; +} + +body { + background-color: $greyscale-grey; +} + +ul { + margin: 0; + padding: 0; +} + +.clearfix { + &::before, + &::after { + content: ""; + display: table; + } + + &::after { + clear: both; + } +} diff --git a/src/media/js/routes.js b/src/media/js/routes.js index a3f0b2d..34e20b5 100644 --- a/src/media/js/routes.js +++ b/src/media/js/routes.js @@ -7,7 +7,8 @@ define('routes', ]); router.api.addRoutes({ - 'hello-names': '/api/v2/hello/names/', + // TODO: Update API url after backend is ready. + 'apps': '/api/v2/fireplace/multi-search/', }); // Processors to set query arguments on API requests. diff --git a/src/media/js/settings_app.js b/src/media/js/settings_app.js index 676d75f..94008be 100644 --- a/src/media/js/settings_app.js +++ b/src/media/js/settings_app.js @@ -23,7 +23,9 @@ define('settings_app', offline_cache_enabled: offline_cache_enabled, offline_cache_limit: 1024 * 1024 * 4, // 4 MB - model_prototypes: {}, + model_prototypes: { + 'apps': 'slug' + }, fragment_error_template: 'errors/fragment.html', pagination_error_template: 'errors/pagination.html', diff --git a/src/templates/homepage.html b/src/templates/homepage.html index e69de29..e557c46 100644 --- a/src/templates/homepage.html +++ b/src/templates/homepage.html @@ -0,0 +1,15 @@ +<div class="app-list"> + {% defer (url=api('apps'), pluck='objects', as='apps', key='slug') %} + <ul class="clearfix"> + {% for app in this %} + <li class="app-list-app"> + <img src="{{ app.previews[0].image_url }}" + alt="{{ app.name }}" title="{{ app.name }}"> + <span class="name">{{ app.name }}</span> + </li> + {% endfor %} + </ul> + {% placeholder %} + <span>loading...</span> + {% end %} +</div>

Joseph Yeh [:joseph]

Assignee

Comment 3

•

9 years ago

Attached patch jostw:josyeh/Marketplace/master/Bug1225354 > mozilla-b2g:master (obsolete) — Details — Splinter Review

Joseph Yeh [:joseph]

Assignee

Comment 4

•

9 years ago

Comment on attachment 8688350 [details] [diff] [review] jostw:josyeh/Marketplace/master/Bug1225354 > mozilla-b2g:master Please ignore the first attachment, I am still not very familiar with Bugzilla...

Attachment #8688350 - Flags: review?(ehung)

David Durst [:ddurst]

Updated

•

9 years ago

Priority: -- → P2

Joseph Yeh [:joseph]

Assignee

Comment 5

•

9 years ago

Attached file jostw:josyeh/Marketplace/master/Bug1225354 > mozilla-b2g:master — Details

Attachment #8688316 - Attachment is obsolete: true

Attachment #8688350 - Attachment is obsolete: true

Attachment #8688350 - Flags: review?(ehung)

Joseph Yeh [:joseph]

Assignee

Updated

•

9 years ago

Attachment #8689336 - Flags: review?(ehung)

Joseph Yeh [:joseph]

Assignee

Comment 6

•

9 years ago

Comment on attachment 8689336 [details] [review] jostw:josyeh/Marketplace/master/Bug1225354 > mozilla-b2g:master I made four commits for this bug. 1. Started from marketplace-template, remove header and footer which is not needed in Marketplace TV. 2. Rename the default view from hello_world to homepage, which is the only view we need. Also remove unused content from hello_world. 3. Install normalize.css from bower and include it in the html. 4. Use defer block to get apps' data from API server and render apps in a row. The API url need update when the backend is ready to use.

Evelyn Hung

Comment 7

•

9 years ago

Comment on attachment 8689336 [details] [review] jostw:josyeh/Marketplace/master/Bug1225354 > mozilla-b2g:master This is the first patch modify from marketplace-template. I quickly went through the patch and it seems just a clean up. I honestly know less about Marketplace frontend code, so it's better to have someone from Marketplace team to review this patch. David and Lindsay, could you find someone who is able to review? Thanks!

Flags: needinfo?(lsaunders)

Flags: needinfo?(ddurst)

Attachment #8689336 - Flags: review?(ehung) → feedback+

David Durst [:ddurst]

Updated

•

9 years ago

Mentor: dspasovski

Flags: needinfo?(lsaunders)

Flags: needinfo?(ddurst)

Joseph Yeh [:joseph]

Assignee

Comment 8

•

9 years ago

Comment on attachment 8689336 [details] [review] jostw:josyeh/Marketplace/master/Bug1225354 > mozilla-b2g:master Hi Davor, There are four commits for this bug and I have described them at https://bugzilla.mozilla.org/show_bug.cgi?id=1225354#c6. Can you help me reviewing this? Thanks!

Attachment #8689336 - Flags: review?(dspasovski)

Josh Cheng [:josh]

Updated

•

9 years ago

blocking-b2g: --- → 2.5+

Priority: P2 → P1

Josh Cheng [:josh]

Updated

•

9 years ago

Whiteboard: [ft:conndevices]

Evelyn Hung

Comment 11

•

9 years ago

Comment on attachment 8689336 [details] [review] jostw:josyeh/Marketplace/master/Bug1225354 > mozilla-b2g:master robberstamp r+ because spasovski gave his r+ on Github.

Attachment #8689336 - Flags: review?(dspasovski) → review+

Joseph Yeh [:joseph]

Assignee

Comment 12

•

9 years ago

Landed in marketplace-tv-front-end master https://github.com/mozilla-b2g/marketplace-tv-front-end/commit/76baa1d31ddce1209b19fa496796b22efe9a0b5f

Status: ASSIGNED → RESOLVED

Closed: 9 years ago

Resolution: --- → FIXED

jostw:josyeh/Marketplace/master/Bug1225354 > mozilla-b2g:master 9 years ago Joseph Yeh [:joseph] 23.00 KB, patch		Details \| Diff \| Splinter Review
jostw:josyeh/Marketplace/master/Bug1225354 > mozilla-b2g:master 9 years ago Joseph Yeh [:joseph] 22.15 KB, patch		Details \| Diff \| Splinter Review
jostw:josyeh/Marketplace/master/Bug1225354 > mozilla-b2g:master 9 years ago Joseph Yeh [:joseph] 62 bytes, text/x-github-pull-request	jj.evelyn : review+ jj.evelyn : feedback+	Details \| Review