1225407 - Replace nsInterfaceHashtable::EnumerateRead() call in SubstitutingProtocolHandler with an iterator

Status: RESOLVED FIXED

(Core :: Networking, defect)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Replace nsInterfaceHashtable::EnumerateRead() call in SubstitutingProtocolHandler with an iterator

Comment 2

[Nicholas Nethercote [inactive]]

Comment on attachment 8688289 [details] [diff] [review]
Replace nsInterfaceHashtable::EnumerateRead() call in SubstitutingProtocolHandler with an iterator

Review of attachment 8688289 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/res/SubstitutingProtocolHandler.cpp
@@ +114,5 @@
>  void
>  SubstitutingProtocolHandler::CollectSubstitutions(InfallibleTArray<SubstitutionMapping>& aMappings)
>  {
> +  for (auto iter = mSubstitutions.ConstIter(); !iter.Done(); iter.Next()) {
> +    auto& key = iter.Key();

I'd inline iter.Key() because it's only used once.

@@ +115,5 @@
>  SubstitutingProtocolHandler::CollectSubstitutions(InfallibleTArray<SubstitutionMapping>& aMappings)
>  {
> +  for (auto iter = mSubstitutions.ConstIter(); !iter.Done(); iter.Next()) {
> +    auto& key = iter.Key();
> +    auto& data = iter.Data();

I'd write the type instead of |auto| because the type is non-obvious. I'd also call it |uri| instead of |data|.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Replace nsInterfaceHashtable::EnumerateRead() call in SubstitutingProtocolHandler with an iterator

Addressed comment 2

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/082fd246bfd3

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/082fd246bfd3