1225456 - Unrecognized page message displayed after tapping on signed in account

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[u549602]

Environment: Beta 
Device : All
Build: Beta 43.0b4 (11-17-2015)

Steps to reproduce:
1. Sign in with a valid account
2. Go to Menu-Settings-Sync
3. Tap on signed in account

Expected result: 
about:accounts page is opened and account management menu displayed 

Actual result: 
The address is not recognized

Please note that this issue occurs also on the Beta 43.0b2 build

For further details please check: https://www.youtube.com/watch?v=k6YjnMIefd8&feature=youtu.be

Comment 1

[Nick Alexander :nalexander [he/him]]

This is odd, I'm surprised this is on Beta 43.  Fallout from Bug 1205418?  Vivek, putting this on your radar in case you can investigate before I can.

I imagine that we've not correctly guarded the link to about:accounts (it should only link if MOZ_NATIVE_ACCOUNT_UI is false).  Or I may have gotten the train schedule confused.

Leaving NI for me to investigate further.

Comment 2

[Vivek Balakrishnan[:vivek]]

@Nick,
We declare the intent in fxaccount_status_prefscreen.xml [1] and programmatically define intent uri at [2]. As we do not return true around [3] it falls through and intent is fired for the open the url.

[1] & [2] was fixed in https://bugzilla.mozilla.org/show_bug.cgi?id=1178378 and uplift to only aurora was requested.


[1] https://mxr.mozilla.org/mozilla-beta/source/mobile/android/base/resources/xml/fxaccount_status_prefscreen.xml#14
[2] http://mxr.mozilla.org/mozilla-beta/source/mobile/android/base/fxa/activities/FxAccountStatusFragment.java#492
[3] http://mxr.mozilla.org/mozilla-beta/source/mobile/android/base/fxa/activities/FxAccountStatusFragment.java#250

Comment 3

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1225456 - Don't launch about:accounts when MOZ_ANDROID_NATIVE_ACCOUNT_UI=1. r?vivek

Bug 1225456 - Don't launch about:accounts when MOZ_ANDROID_NATIVE_ACCOUNT_UI=1. r?vivek

I haven't been able to test this, since the patch is relevant to Nightly
but the behaviour doesn't happen.

Comment 4

[Vivek Balakrishnan[:vivek]]

Comment on attachment 8693083 [details]
MozReview Request: Bug 1225456 - Don't launch about:accounts when MOZ_ANDROID_NATIVE_ACCOUNT_UI=1. r?vivek

https://reviewboard.mozilla.org/r/26391/#review23899

LGTM.

Comment 5

[Nick Alexander :nalexander [he/him]]

https://hg.mozilla.org/integration/fx-team/rev/43ae4742c4c0ea0eefdb99ecc9b7c8a88715b03d
Bug 1225456 - Don't launch about:accounts when MOZ_ANDROID_NATIVE_ACCOUNT_UI=1. r=vivek

Comment 6

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8693083 [details]
MozReview Request: Bug 1225456 - Don't launch about:accounts when MOZ_ANDROID_NATIVE_ACCOUNT_UI=1. r?vivek

Approval Request Comment
[Feature/regressing bug #]: 

Adding "manage account" link to the status activity: https://bugzilla.mozilla.org/show_bug.cgi?id=1205418

[User impact if declined]: tapping the account name takes the user to a failing page with an error message.

[Describe test coverage new/current, TreeHerder]: very little.  I tested a frankenbuild with the fix, but it's hard to produce a beta build with the right configuration.

[Risks and why]: very low.

[String/UUID change made/needed]: none.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/43ae4742c4c0

Comment 8

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8693083 [details]
MozReview Request: Bug 1225456 - Don't launch about:accounts when MOZ_ANDROID_NATIVE_ACCOUNT_UI=1. r?vivek

Fix for a signin problem on android, please uplift to aurora and beta. 
It would be good to verify this on both channels next week; this should be on the RC build which is aimed to release on Tuesday.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/28e573c9ef56

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-release/rev/856daabe1d47

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/e83f44a34564

Comment 12

[u421692]

This issue is still reproducing on Firefox 43 Beta 10; so it might very well reproduce on the RC build.
Any ideas?

Comment 13

[u421692]

This issue is reproducing in Firefox 43 Release candidate. 
Should we fix this or wait for the 44 build?

Comment 14

[Nick Alexander :nalexander [he/him]]

(In reply to Mihai Pop from comment #13)
> This issue is reproducing in Firefox 43 Release candidate. 
> Should we fix this or wait for the 44 build?

Not worth burning too much on this.  It's addressed in Nightly; let's ship this bug to reduce risk and churn, and pick it up for Beta 44.

Comment 16

[Nick Alexander :nalexander [he/him]]

(In reply to Carsten Book [:Tomcat] from comment #10)
> https://hg.mozilla.org/releases/mozilla-release/rev/856daabe1d47

Ah, this patch did not get applied properly :(  The source files moved around, so what should have been a one line patch now creates a file in the middle of nowhere.  That explains at least why the fix did not succeed.  Mihai, thanks for your report -- I was busy with Mozlando so I didn't dig into the cause until now :(

I think we should try to address this for 44.  I can create a backout and branch patch if needed.  Liz, is that sensible?

Comment 17

[Richard Newman [:rnewman]]

Liz was going to cut another 43.0 RC for Bug 1230206, so if you really need this correctly applied in 43, I imagine it's possible.

Comment 18

[Nick Alexander :nalexander [he/him]]

(In reply to Richard Newman [:rnewman] from comment #17)
> Liz was going to cut another 43.0 RC for Bug 1230206, so if you really need
> this correctly applied in 43, I imagine it's possible.

Sadly, this train has ridden.  I'll make sure we're correct on beta and aurora now.

Comment 19

[u421692]

Verified as fixed on Firefox 44 Beta 1

Comment 20

[Nick Alexander :nalexander [he/him]]

(In reply to Mihai Pop from comment #19)
> Verified as fixed on Firefox 44 Beta 1

Thanks Mihai!  Really appreciate all your work on this ticket.

Comment 21

[u421692]

Verified as fixed on Firefox 45 Beta 1