Open Bug 1225466 Opened 4 years ago Updated 2 years ago

Several issues with Edge migration on newer builds of Windows 10

Categories

(Firefox :: Migration, defect)

All
Windows 10
defect
Not set

Tracking

()

Tracking Status
firefox42 - wontfix
firefox43 + wontfix
firefox44 - affected
firefox45 - affected

People

(Reporter: vasilica.mihasca, Unassigned)

References

(Blocks 1 open bug)

Details

- Reproducible on: Firefox 45.0a1 (2015-11-16), Firefox 44.0a2 (2015-11-16) and Firefox 43 beta 4 under latest insider windows version 1511 (OS Build 10586.0)
- This issue is not reproducible using the release version of Windows 10.0 (Build 10240)

STR
1.Run Firefox for the first time or remove the profiles folder.
2.Select Edge from the "Import Settings and Data" window and click on “Next” button.
3.Press "Next" and then “Finish” buttons.
4.Check the imported bookmarks, reading list items, browsing history, passwords, cookies and the Browser Console.

ER
Firefox has all the other browser's bookmark, login data, reading list items, browsing history and cookies imported.

AR
[1] Browsing history and reading list items are not imported.
[2] The recently deleted bookmarks are still imported.
[3] The following errors are thrown in browser console.

Error reading typed URL history: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWindowsRegKey.open]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource:///modules/MSMigrationUtils.jsm :: getTypedURLs :: line 722"  data: no] MSMigrationUtils.jsm:763:0
Get a connection to permissions.sqlite.
DB table(moz_perms) is created!
While creating services from category 'profile-after-change', service for entry 'Sapi Speech Synth', contract ID '@mozilla.org/synthsapi;1' does not implement nsIObserver.
Unable to get item: 1168 MSMigrationUtils.jsm:861:0
some passwords did not successfully migrate.
dbPath is not defined MSMigrationUtils.jsm:490:0
some bookmarks did not successfully migrate.


Additional notes:
- This issue is reproducible on Firefox 45.0a1 (2015-11-16), Firefox 44.0a2 (2015-11-16) and Firefox 43 Beta 4 (20151116155110) under Windows 10 64-bit insider windows version 1511 (OS Build 10586.0)
I've also reproduce this issue on Firefox 42 RC under Windows 10 64-bit insider Windows version 1511 (OS Build 10586.0) which means that this regression is not caused from our side.
Tracking since this is a regression.
(In reply to Vasilica Mihasca, QA [:vasilica_mihasca] from comment #0)
> [1] Browsing history and reading list items are not imported.

Is this history from navigating or from actually typing URLs into the URL bar (or the thing that shows up in the new tab page)?

> [2] The recently deleted bookmarks are still imported.

Can you elaborate on this? When did you create the bookmarks and when did you delete them? Your comment didn't specify.

> [3] The following errors are thrown in browser console.
> 
> Error reading typed URL history: [Exception... "Component returned failure
> code: 0x80004005 (NS_ERROR_FAILURE) [nsIWindowsRegKey.open]"  nsresult:
> "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame ::
> resource:///modules/MSMigrationUtils.jsm :: getTypedURLs :: line 722"  data:
> no] MSMigrationUtils.jsm:763:0

This indicates that we found no history that you typed in the URL bar. That is possible if there was no such history, or if the history was moved or Edge no longer stores it there. Can you clarify?

> Get a connection to permissions.sqlite.
> DB table(moz_perms) is created!
> While creating services from category 'profile-after-change', service for
> entry 'Sapi Speech Synth', contract ID '@mozilla.org/synthsapi;1' does not
> implement nsIObserver.

These messages are unrelated to migration.

> Unable to get item: 1168 MSMigrationUtils.jsm:861:0

This is an error from the passwords migrator. Were any passwords missing? comment #0 did not specify.

> some passwords did not successfully migrate.

> dbPath is not defined MSMigrationUtils.jsm:490:0

This is a stupid error in the error handling code for reading list. I'll fix that shortly. I can reproduce the reading list issue, but favorites seem to import OK.
Flags: needinfo?(vasilica.mihasca)
Blocks: 1225798
Blocks: 1225800
No longer blocks: 1225800
Depends on: 1225800
No longer blocks: 1225798
Depends on: 1225798
Depends on: 1226198
(In reply to :Gijs Kruitbosch from comment #3)

> Is this history from navigating or from actually typing URLs into the URL
> bar (or the thing that shows up in the new tab page)?

Only the websites that I actually typed in the url bar are migrated as history.
The pages opened from the new tab page and the history from navigating are not imported.


> Can you elaborate on this? When did you create the bookmarks and when did
> you delete them? Your comment didn't specify.

Before performing the migration process I deleted a few favorites and added new ones in Edge, but in Firefox are imported another bookmarks, such as very old ones.
See screenshot: http://i.imgur.com/HMcT6cy.jpg


> This indicates that we found no history that you typed in the URL bar. That
> is possible if there was no such history, or if the history was moved or
> Edge no longer stores it there. Can you clarify?

You are right.I did not have any typed Url history.


> This is an error from the passwords migrator. Were any passwords missing?
> comment #0 did not specify.

Apparently all my passwords are imported. 


Also encountered a new issue while migrating from Edge: Bug 1226198
Flags: needinfo?(vasilica.mihasca)
Depends on: 1226556
I'm not really sure I understand why this needs to be tracked for a release if it's not a regression in that release, but in Windows' behaviour. I'm not saying we shouldn't investigate and fix, but I don't think tracking this bug is going to help.
Summary: Edge migration is broken on Windows 10 → Several issues with Edge migration on newer builds of Windows 10
(In reply to :Gijs Kruitbosch from comment #5)
> I'm not really sure I understand why this needs to be tracked for a release
> if it's not a regression in that release, but in Windows' behaviour. I'm not
> saying we shouldn't investigate and fix, but I don't think tracking this bug
> is going to help.

Because users don't care who is to blame but that things stopped working and need to work again.
(In reply to Robert Kaiser (:kairo@mozilla.com) from comment #6)
> (In reply to :Gijs Kruitbosch from comment #5)
> > I'm not really sure I understand why this needs to be tracked for a release
> > if it's not a regression in that release, but in Windows' behaviour. I'm not
> > saying we shouldn't investigate and fix, but I don't think tracking this bug
> > is going to help.
> 
> Because users don't care who is to blame but that things stopped working and
> need to work again.

I don't need a lecture on how users feel about this, thanks. My point is, in a sense we are already shipping this. We should address it ASAP but tying it to a particular release does not feel useful.

Maybe I should be more assertive: given my other commitments, the lack of clarity around what is causing the issues, and the fact that we are now in late beta, I am not particularly confident we can fix this for 43, and rushing to try to accomplish that seems counterproductive to me.
Also note that this is far from "completely broken for everyone" and it is really not clear that this is even actually an issue with a particular release of Win10 rather than just "different machine, different data" which is causing different behaviour in the migrator.
Depends on: 1229076
Sounds like a few different bugs, many already fixed, nothing sounded like an emergency that has to be fixed in 43. Sorry I didn't see your response earlier.  We do track things that aren't release blockers, when people suggest they may be important.
OK, let's untrack this bug. We shipped several releases already and it doesn't really seem actionable.
While testing on Windows 10 x 64, using FF 44.0b6 i noticed a few issues related to the bookmarks migration from Edge:
- if importing settings and data from Edge on the first run, the Bookmarks are not imported;
- if importing settings and data from Edge, using about:preferences#security -> 'Saved Logins', or from 'Show All Bookmarks', only an empty folder is created in the Bookmarks list;  
Note that in the Edge browser, at least one website is saved in both Favorites and Favorites Bar.
Should I file a new bug for this issue?
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to Mihai Boldan, QA [:mboldan] from comment #11)
> While testing on Windows 10 x 64, using FF 44.0b6 i noticed a few issues
> related to the bookmarks migration from Edge:
> - if importing settings and data from Edge on the first run, the Bookmarks
> are not imported;
> - if importing settings and data from Edge, using about:preferences#security
> -> 'Saved Logins', or from 'Show All Bookmarks', only an empty folder is
> created in the Bookmarks list;  
> Note that in the Edge browser, at least one website is saved in both
> Favorites and Favorites Bar.
> Should I file a new bug for this issue?

The bookmarks issue is already filed, it's bug 1226556.
Flags: needinfo?(gijskruitbosch+bugs)
Depends on: 1237679
To clarify, was the original bookmarks issue reported in this bug covered by bug 1226556? If so, is the only remaining issue that we only import typed URLs from Edge? In which case should we change the title to be more clear?

Additionally, do we have any idea at a high level where we would read the full Edge history? IE exposed an API for enumerating its history, but as far as I can discover there is no such API for Edge and no plans to implement one.
(In reply to Doug Thayer [:dthayer] from comment #13)
> To clarify, was the original bookmarks issue reported in this bug covered by
> bug 1226556?

I believe so.

> If so, is the only remaining issue that we only import typed
> URLs from Edge? In which case should we change the title to be more clear?

That would be a good idea. That or explicitly make this a metabug and file a specific bug for the history issue - there's already a number of dependencies.

> Additionally, do we have any idea at a high level where we would read the
> full Edge history?

See bug 1192034, esp. bug 1192034 comment 6. Note that this is by far the most crazy digging I've ever done in Windows internals. Which isn't attempting to brag but rather the opposite: perhaps someone with more experience of how to dig at Windows-internal stuff can work out something better here.

I also asked some MS folks that we had contact details for but that thread didn't go anywhere, back in the day. We could ask again... I'll forward you what I have.

> IE exposed an API for enumerating its history, but as far
> as I can discover there is no such API for Edge and no plans to implement
> one.

Right, that's where I ended up 2 years ago, too. :-(
You need to log in before you can comment on or make changes to this bug.