1237679 - Edge migration should tell you to close the browser before attempting to migrate

Status: VERIFIED FIXED

(Firefox :: Migration, defect)

Description

[:Gijs (he/him)]

IME the databases stay locked, and that even lasts a few seconds after the last Edge window disappears. While we can easily tell users to close the browser (by setting sourceLocked on the migrator object to true), I don't think we currently implement a way to check and wait for the source to be unlocked, or something like this... which it might be worth doing.

Comment 1

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1237679 - use sourceLocked to ensure users get warned to close the browser before running the migration, r?MattN

Review commit: https://reviewboard.mozilla.org/r/32781/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/32781/

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8713231 [details]
MozReview Request: Bug 1237679 - use sourceLocked to ensure users get warned to close the browser before running the migration, r?MattN

https://reviewboard.mozilla.org/r/32781/#review29921

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/517bc7ebc8b1

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/517bc7ebc8b1

Comment 5

[:Gijs (he/him)]

Comment on attachment 8713231 [details]
MozReview Request: Bug 1237679 - use sourceLocked to ensure users get warned to close the browser before running the migration, r?MattN

Asking for uplift because of bug 1226556 which sort of needs this one

Approval Request Comment
[Feature/regressing bug #]: windows 10 update meant an even stronger dependency on the ESE database in which Edge used to only store reading list, now also stores bookmarks
[User impact if declined]: Users wouldn't know that they need to close Edge before trying to import bookmarks. If Edge is not closed, we cannot access the database in which bookmarks and reading list are stored.
[Describe test coverage new/current, TreeHerder]: no. :-(
[Risks and why]: very low - all this does is essentially flip a boolean switch that will cause the migration UI to show a warning to the user. We already do this for Chrome, where our migration code has a similar issue.
[String/UUID change made/needed]: no, we're using existing strings.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8713231 [details]
MozReview Request: Bug 1237679 - use sourceLocked to ensure users get warned to close the browser before running the migration, r?MattN

Improve the import situation, taking it.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Should be in 45 beta 5.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/83c4d1408880

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3ad49ca34619

Comment 10

[Cornel Ionce [:noni] [Hubs QA]]

The "Please ensure the selected browser is closed before continuing." message is now correctly displayed when trying to import data from Microsoft Edge on Windows 10 x64.

Tested using:
- Firefox 45.0b8, buildID 20160221141421,
- 2016-02-22 Aurora 46.0a2 and 
- 2016-02-22 Nightly 47.0a1.