1225703 - Update in-tree libcubeb

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect)

Description

[Matthew Gregan [:kinetik]]

Update out in-tree libcubeb to bring in the device enumeration changes and whatever else has changed since the last update.

I've synced several changes to the Gecko version back to the upstream cubeb, but this is becoming a major pain because these changes are being made without my awareness and it is VERY easy to accidentally revert changes when changes are made in both locations.

Some of the changes don't even make sense for third-party code, such as the ScopedXPCOM guff added in bug 1219480.

So, from here on out, changes must be upstreamed into libcubeb and then updated into Gecko using the update script.

Comment 1

[Matthew Gregan [:kinetik]]

CC :rillian, see above comment re bug 1219480 changes.

Comment 2

[Matthew Gregan [:kinetik]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5c861e39d074

Comment 3

[Matthew Gregan [:kinetik]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=37281219e2ed

Comment 4

[Matthew Gregan [:kinetik]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ccaea0ac2aff

Comment 5

[Matthew Gregan [:kinetik]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5c8b725d4f79

Comment 6

[Matthew Gregan [:kinetik]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f078b58fd53

Comment 7

[Matthew Gregan [:kinetik]]

Attachment: v0

Comment 8

[Paul Adenot (:padenot)]

Comment on attachment 8689860 [details] [diff] [review]
v0

Review of attachment 8689860 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

Comment 9

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3f51676191a6be10a6321edd49662a73a21e381d
Bug 1225703 - Update in-tree libcubeb.  r=padenot

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out for windows cpp unittest failures: https://treeherder.mozilla.org/logviewer.html#?job_id=17666540&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/042f728628d1

Comment 12

[Matthew Gregan [:kinetik]]

Sorry, obviously missed that failure in the try runs.

This is caused by 09b3e5e4, which made the WASAPI backend reject streams with a format other than CUBEB_SAMPLE_FLOAT32NE (because it never supported them).  test_audio and test_sanity try to open streams with CUBEB_SAMPLE_S16LE.

Comment 13

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8631caf756eb6abf821a15a57a095a98d6f23af5
Bug 1225703 - Update in-tree libcubeb.  r=padenot

Comment 14

[Nigel Babu [:nigelb]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/48139ac411625d1ee8b21c51770b917502dba1d9
Backed out changeset 8631caf756eb (bug 1225703) for Cpp bustage on OS X 10.10 debug

Comment 15

[Nigel Babu [:nigelb]]

Backed out for bustages like https://treeherder.mozilla.org/logviewer.html#?job_id=17919677&repo=mozilla-inbound on OS X 10.10 (both opt and debug, unlike what what the commit message claims)

Comment 16

[Matthew Gregan [:kinetik]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b7928a570593

Comment 17

[Matthew Gregan [:kinetik]]

(In reply to Nigel Babu [:nigelb] from comment #15)
> Backed out for bustages like
> https://treeherder.mozilla.org/logviewer.html#?job_id=17919677&repo=mozilla-
> inbound on OS X 10.10 (both opt and debug, unlike what what the commit
> message claims)

For some reason the Cpp tests didn't run on 10.10 for my Try push so I didn't catch this.  Reproduced, fixed, and tested on a local 10.11 machine, so should be fine this time around.

Comment 18

[Matthew Gregan [:kinetik]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c23c3ac6ff9

Comment 19

[Matthew Gregan [:kinetik]]

(In reply to Matthew Gregan [:kinetik] from comment #18)
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=7c23c3ac6ff9

This is with (just) 10.10 enabled.

Comment 20

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ce50ce20308c66be2772a856d10c00c99c83d4af
Bug 1225703 - Update in-tree libcubeb.  r=padenot

Comment 21

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ce50ce20308c