1225722 - Implement RTCCodecStats

Status: RESOLVED FIXED

(Core :: WebRTC, enhancement, P2)

Description

[Andreas Pehrson [:pehrsons]]

We have the WebIDL for RTCCodecStats but it's not being populated. In the spec [1] it has changed name to RTCCodec and I can't see how one would get its hands on an instance of RTCCodec, but when that's defined we should implement it.

[1] https://w3c.github.io/webrtc-stats/archives/20151023/webrtc-stats.html#dictionary-rtccodec-members

Comment 1

[Andreas Pehrson [:pehrsons]]

(In reply to Andreas Pehrson [:pehrsons] (Telenor) from comment #0)
> I can't see how one would get its hands on an instance of RTCCodec

Nvm, it at least says in webrtc-pc [2] that it'll be top-level in the returned dict.

[2] https://w3c.github.io/webrtc-pc/archives/20151006/webrtc.html#idl-def-RTCStatsReport

Comment 2

[Bulk Bug Changes for mreavy's org]

Mass change P2->P3 to align with new Mozilla triage process.

Comment 4

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1225722 - Test RTCCodecStats in stats.js. r?jib!

Comment 5

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1225722 - Add mochitest for one-way stats in order to test RTCCodecType. r?jib!

Comment 6

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1225722 - Test RTCCodecStats in test_pc_videoCodecs.html to verify payloadTypes. r?jib!

Comment 7

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1225722 - Move DataChannelStats to non-internal section in webidl. r?#webidl!, r?jib!

Comment 8

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1225722 - Add RTCCodecStats webidl. r?#webidl!, r?jib!

Comment 9

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1225722 - Make PeerConnectionImpl::GetSenderStats take a TransceiverImpl. r?bwc!

This allows us to round up codec, receiver and sender stats from within the same
loop (over transceivers).

Comment 10

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1225722 - Modularize RTCStatsIdGenerator::RewriteIds somewhat. r?bwc!

Comment 11

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1225722 - Wire up RTCCodecStats from GetStats. r?jib!, r?bwc!

Comment 12

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1225722 - Implement getters in the conduits for currently active payload types. r?bwc!

Comment 13

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1225722 - Constify some JsepSessionImpl getters. r?bwc!

Comment 14

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1225722 - Populate and coalesce RTCCodecStats to transport-level. r?jib!, r?bwc!

Comment 15

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1225722 - Update WPT expectations. r?jib!

Comment 16

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1225722 - Generalize some stats helpers with parameter expansion. r?bwc

This patch has two goals:

• In RTCStatsIdGenerator::RewriteIds avoid having to write a lambda for each
  stat dict member that can be an id
• Have a single place in C++-land that explicitly lists public and internal
  RTCStatsCollection members, to reduce the number of locations that need
  updating when adding new stats.

Comment 17

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1225722 - jsep_track_unittest: Only log sdp and codecs on failure. r?bwc!

Comment 18

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1225722 - Make the MediaType in JsepCodecDescription instances static. r?bwc!

Comment 19

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1225722 - Create JsepCodecDescription instances through factory methods. r?bwc!

This is mainly to avoid repeating the default parameters throughout the tree.

Comment 20

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1225722 - Add sdpFmtpLine to JsepCodecDescription. r?bwc!

Comment 21

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1225722 - Test RTCCodecStats coalescing in mochitest. r?jib!

Comment 22

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1225722 - Test RTCCodecStats NOT coalescing in mochitest. r?jib!

Comment 23

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1225722 - Filter codec stats based on selectors and active payload types. r?jib!, r?bwc!

Comment 24

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1225722 - Add StatsId() to JsepCodecDescription. r?bwc!

Comment 25

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1225722 - Make nsTArray of std::tuple movable. r?#xpcom-reviewers!

Comment 26

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1225722 - Less restrictive non-memmovable static analysis of std::tuple. r?nika

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ec4aee8e9a4
Test RTCCodecStats in stats.js. r=jib
https://hg.mozilla.org/integration/autoland/rev/cdbd947566bc
Add mochitest for one-way stats in order to test RTCCodecType. r=jib
https://hg.mozilla.org/integration/autoland/rev/370bdfb76ac7
Test RTCCodecStats in test_pc_videoCodecs.html to verify payloadTypes. r=jib
https://hg.mozilla.org/integration/autoland/rev/a75366a4ea6c
Test RTCCodecStats coalescing in mochitest. r=jib
https://hg.mozilla.org/integration/autoland/rev/f394081bcd09
Test RTCCodecStats NOT coalescing in mochitest. r=jib
https://hg.mozilla.org/integration/autoland/rev/8e2392662557
Move DataChannelStats to non-internal section in webidl. r=jib,webidl,smaug
https://hg.mozilla.org/integration/autoland/rev/8015aa7f593b
Add RTCCodecStats webidl. r=jib,webidl,smaug
https://hg.mozilla.org/integration/autoland/rev/f2e78d88e87f
jsep_track_unittest: Only log sdp and codecs on failure. r=bwc
https://hg.mozilla.org/integration/autoland/rev/bfd29442ed2f
Make the MediaType in JsepCodecDescription instances static. r=bwc
https://hg.mozilla.org/integration/autoland/rev/d8231354d400
Create JsepCodecDescription instances through factory methods. r=bwc
https://hg.mozilla.org/integration/autoland/rev/ab3da5998395
Add sdpFmtpLine to JsepCodecDescription. r=bwc
https://hg.mozilla.org/integration/autoland/rev/9bd71989a943
Add StatsId() to JsepCodecDescription. r=bwc
https://hg.mozilla.org/integration/autoland/rev/e928fcf303ab
Make PeerConnectionImpl::GetSenderStats take a TransceiverImpl. r=bwc
https://hg.mozilla.org/integration/autoland/rev/79e8569a7cb8
Modularize RTCStatsIdGenerator::RewriteIds somewhat. r=bwc
https://hg.mozilla.org/integration/autoland/rev/dad900244739
Wire up RTCCodecStats from GetStats. r=bwc,jib
https://hg.mozilla.org/integration/autoland/rev/bfeee66fdda5
Generalize some stats helpers with parameter expansion. r=bwc
https://hg.mozilla.org/integration/autoland/rev/e37cfe95a439
Implement getters in the conduits for currently active payload types. r=bwc
https://hg.mozilla.org/integration/autoland/rev/2dea88c02e3f
Constify some JsepSessionImpl getters. r=bwc
https://hg.mozilla.org/integration/autoland/rev/174d81cefb2c
Populate and coalesce RTCCodecStats to transport-level. r=bwc,jib
https://hg.mozilla.org/integration/autoland/rev/6ddab7982ef5
Filter codec stats based on selectors and active payload types. r=bwc,jib
https://hg.mozilla.org/integration/autoland/rev/7c8e0d60d269
Update WPT expectations. r=jib
https://hg.mozilla.org/integration/autoland/rev/c0ea85240e32
Less restrictive non-memmovable static analysis of std::tuple. r=nika

Comment 28

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/3ec4aee8e9a4
https://hg.mozilla.org/mozilla-central/rev/cdbd947566bc
https://hg.mozilla.org/mozilla-central/rev/370bdfb76ac7
https://hg.mozilla.org/mozilla-central/rev/a75366a4ea6c
https://hg.mozilla.org/mozilla-central/rev/f394081bcd09
https://hg.mozilla.org/mozilla-central/rev/8e2392662557
https://hg.mozilla.org/mozilla-central/rev/8015aa7f593b
https://hg.mozilla.org/mozilla-central/rev/f2e78d88e87f
https://hg.mozilla.org/mozilla-central/rev/bfd29442ed2f
https://hg.mozilla.org/mozilla-central/rev/d8231354d400
https://hg.mozilla.org/mozilla-central/rev/ab3da5998395
https://hg.mozilla.org/mozilla-central/rev/9bd71989a943
https://hg.mozilla.org/mozilla-central/rev/e928fcf303ab
https://hg.mozilla.org/mozilla-central/rev/79e8569a7cb8
https://hg.mozilla.org/mozilla-central/rev/dad900244739
https://hg.mozilla.org/mozilla-central/rev/bfeee66fdda5
https://hg.mozilla.org/mozilla-central/rev/e37cfe95a439
https://hg.mozilla.org/mozilla-central/rev/2dea88c02e3f
https://hg.mozilla.org/mozilla-central/rev/174d81cefb2c
https://hg.mozilla.org/mozilla-central/rev/6ddab7982ef5
https://hg.mozilla.org/mozilla-central/rev/7c8e0d60d269
https://hg.mozilla.org/mozilla-central/rev/c0ea85240e32