1745707 - RTCRtpReceiver Stats IDs should be opaque

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P2)

Description

[Andreas Pehrson [:pehrsons]]

Bug 1602739 made stats ids opaque for RTCPeerConnection's getStats(). However, RTCRtpReceiver's getStats() provide predictable ids still.

+++ This bug was initially created as a clone of Bug #1602739 +++

Stats IDs should not be predictable, which they are in their current state. We should change this to avoid web compat issues.

Comment 1

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1745707 - Test for opaque id in receiver getStats. r?ng!

Comment 2

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1745707 - Put id-rewriting into the id generator. r?ng!

As the id generator is already a shared resource, this seems like a natural fit.

Comment 3

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1745707 - Rewrite ids in the RTCRtpReceiver::GetStats() path. r?ng!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/927203d412ab
Test for opaque id in receiver getStats. r=ng
https://hg.mozilla.org/integration/autoland/rev/74b13a5823f4
Put id-rewriting into the id generator. r=ng
https://hg.mozilla.org/integration/autoland/rev/96ddca9a7a90
Rewrite ids in the RTCRtpReceiver::GetStats() path. r=ng

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/927203d412ab
https://hg.mozilla.org/mozilla-central/rev/74b13a5823f4
https://hg.mozilla.org/mozilla-central/rev/96ddca9a7a90