1225755 - reduce mozversion logging noise

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[Julien Pagès (:parkouss)]

I think that output like:

> 0:12.38 LOG: MainThread mozversion INFO application_buildid: 20150921144335
> 0:12.38 LOG: MainThread mozversion INFO application_changeset: 6c90d3eab1f7f9cbc195a6c0dad7f4cf39368237
> 0:12.38 LOG: MainThread mozversion INFO application_display_name: Nightly
> 0:12.38 LOG: MainThread mozversion INFO application_id: {ec8030f7-c20a-464f-9b0e-13a3a9e97384}
> 0:12.38 LOG: MainThread mozversion INFO application_name: Firefox
> 0:12.38 LOG: MainThread mozversion INFO application_remotingname: firefox
> 0:12.38 LOG: MainThread mozversion INFO application_repository: https://hg.mozilla.org/integration/mozilla-inbound
> 0:12.38 LOG: MainThread mozversion INFO application_vendor: Mozilla
> 0:12.38 LOG: MainThread mozversion INFO application_version: 44.0a1
> 0:12.38 LOG: MainThread mozversion INFO platform_buildid: 20150921144335
> 0:12.38 LOG: MainThread mozversion INFO platform_changeset: 6c90d3eab1f7f9cbc195a6c0dad7f4cf39368237
> 0:12.38 LOG: MainThread mozversion INFO platform_repository: https://hg.mozilla.org/integration/mozilla-inbound
> 0:12.38 LOG: MainThread mozversion INFO platform_version: 44.0a1

Is too much verbose. Not everything is interesting in there.

I would vote to remove the following keys:

- application_display_name
- application_id
- application_remotingname
- application_vendor
- platform*

I don't think we need a fallback (an option that could reactivate those values), but that's open to discussion.

Comment 1

[Julien Pagès (:parkouss)]

Attachment: reduce mozversion logs

So this is based on the work of the PR in bug 1214386. Only the last commit should be reviewed here.

The patch does what I said in comment 0 - if you disagree, then ofc let's discuss that. I would not remove an important log line.

Comment 2

[William Lachance (:wlach)]

Comment on attachment 8688887 [details] [review]
reduce mozversion logs

I'm cool with this landing, though have some concerns on the size of the change given what it's doing. It would be great if it were easier to achieve this behaviour somehow.

Comment 3

[Julien Pagès (:parkouss)]

(In reply to William Lachance (:wlach) from comment #2)
> Comment on attachment 8688887 [details] [review]
> reduce mozversion logs
> 
> I'm cool with this landing, though have some concerns on the size of the
> change given what it's doing. It would be great if it were easier to achieve
> this behaviour somehow.

Right :)

I used a regexp instead of all that code, looks nicer to me:

https://github.com/parkouss/mozregression/commit/2d779d2c48fe7bc37af6e37204920f2f64c8177f

Comment 4

[Julien Pagès (:parkouss)]

Landed in https://github.com/mozilla/mozregression/commit/fa2289cb39bc201b9d5a59b5c6c3dfacb32b7f97.