Closed Bug 1225877 Opened 4 years ago Closed 1 year ago

Parse latest a=simulcast and a=rid

Categories

(Core :: WebRTC: Signaling, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox45 --- wontfix
firefox68 --- fixed
Blocking Flags:

People

(Reporter: bwc, Assigned: bwc)

References

Details

Attachments

(2 files, 2 obsolete files)

No description provided.
Assignee: nobody → docfaraday
Rank: 10
Priority: -- → P1
backlog: --- → webrtc/webaudio+
Byron -- What else remains to be done on this bug?  

I've lowered this to a Rank of 15, but if this is just about spec clean up, perhaps it should be lower.  Let me know what you think.
Rank: 10 → 15
Flags: needinfo?(docfaraday)
It depends on what kinds of changes we expect to see; there is no 04 yet.
Flags: needinfo?(docfaraday)
Ok, thanks - I see this as "file all necessary bugs once Simulcast-04 is available" and there's no action until then.
Summary: Update a=simulcast to 04 draft → Update a=simulcast to 04 draft and a=rid to 05 draft
Comment on attachment 8752385 [details]
MozReview Request: Bug 1225877 - Part 1: Update simulcast ABNF. r?drno

https://reviewboard.mozilla.org/r/52575/#review49768
Attachment #8752385 - Flags: review?(drno) → review+
Comment on attachment 8752386 [details]
MozReview Request: Bug 1225877 - Part 2: Handle paused rids (basically just ignore that they're paused for now). r?drno

https://reviewboard.mozilla.org/r/52577/#review49806

::: media/webrtc/signaling/src/jsep/JsepTrack.cpp:190
(Diff revision 1)
>        rid.id = constraints.rid;
>        rid.direction = direction;
>        rids->mRids.push_back(rid);
>  
>        SdpSimulcastAttribute::Version version;
> -      version.choices.push_back(constraints.rid);
> +      SdpSimulcastAttribute::Version::Choice choice = {false, constraints.rid};

A TODO with a bug number might be helpful here.

::: media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp:2480
(Diff revision 1)
>      for (auto& encoding : aParameters.mEncodings.Value()) {
>        JsepTrack::JsConstraints constraint;
>        if (encoding.mRid.WasPassed()) {
>          constraint.rid = NS_ConvertUTF16toUTF8(encoding.mRid.Value()).get();
>        }
> +      constraint.paused = false;

Same TODO with bug number
Attachment #8752386 - Flags: review?(drno) → review+
Mass change P1->P2 to align with new Mozilla triage process
Priority: P1 → P2
Summary: Update a=simulcast to 04 draft and a=rid to 05 draft → Update a=simulcast and a=rid to latest drafts
Blocks: 1470568
Duplicate of this bug: 1191986
Summary: Update a=simulcast and a=rid to latest drafts → Parse latest a=simulcast and a=rid
Attachment #8752385 - Attachment is obsolete: true
Attachment #8752386 - Attachment is obsolete: true
Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/17c6c03c439e
Part 0: Test-case updates. r=mjf
https://hg.mozilla.org/integration/autoland/rev/1fb8d0d598d0
Part 1: Parse simulcast without rid= or pt= r=mjf
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.