1225877 - Parse latest a=simulcast and a=rid

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P2)

Comment 1

[Maire Reavy [:mreavy]]

Byron -- What else remains to be done on this bug?  

I've lowered this to a Rank of 15, but if this is just about spec clean up, perhaps it should be lower.  Let me know what you think.

Comment 2

[Byron Campen [:bwc]]

It depends on what kinds of changes we expect to see; there is no 04 yet.

Comment 3

[Maire Reavy [:mreavy]]

Ok, thanks - I see this as "file all necessary bugs once Simulcast-04 is available" and there's no action until then.

Comment 4

[Byron Campen [:bwc]]

Attachment: MozReview Request: Bug 1225877 - Part 1: Update simulcast ABNF. r?drno

Review commit: https://reviewboard.mozilla.org/r/52575/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52575/

Comment 5

[Byron Campen [:bwc]]

Attachment: MozReview Request: Bug 1225877 - Part 2: Handle paused rids (basically just ignore that they're paused for now). r?drno

Review commit: https://reviewboard.mozilla.org/r/52577/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/52577/

Comment 6

[Nils Ohlmeier [:drno]]

Comment on attachment 8752385 [details]
MozReview Request: Bug 1225877 - Part 1: Update simulcast ABNF. r?drno

https://reviewboard.mozilla.org/r/52575/#review49768

Comment 7

[Nils Ohlmeier [:drno]]

Comment on attachment 8752386 [details]
MozReview Request: Bug 1225877 - Part 2: Handle paused rids (basically just ignore that they're paused for now). r?drno

https://reviewboard.mozilla.org/r/52577/#review49806

::: media/webrtc/signaling/src/jsep/JsepTrack.cpp:190
(Diff revision 1)
>        rid.id = constraints.rid;
>        rid.direction = direction;
>        rids->mRids.push_back(rid);
>  
>        SdpSimulcastAttribute::Version version;
> -      version.choices.push_back(constraints.rid);
> +      SdpSimulcastAttribute::Version::Choice choice = {false, constraints.rid};

A TODO with a bug number might be helpful here.

::: media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp:2480
(Diff revision 1)
>      for (auto& encoding : aParameters.mEncodings.Value()) {
>        JsepTrack::JsConstraints constraint;
>        if (encoding.mRid.WasPassed()) {
>          constraint.rid = NS_ConvertUTF16toUTF8(encoding.mRid.Value()).get();
>        }
> +      constraint.paused = false;

Same TODO with bug number

Comment 8

[Bulk Bug Changes for mreavy's org]

Mass change P1->P2 to align with new Mozilla triage process

Comment 10

[Byron Campen [:bwc]]

Attachment: Bug 1225877 - Part 0: Test-case updates. r?mjf

Comment 11

[Byron Campen [:bwc]]

Attachment: Bug 1225877 - Part 1: Parse simulcast without rid= or pt= r?mjf

Depends on D28243

Comment 12

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=141627752347af056d58fa187b2d625101c23eb6

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17c6c03c439e
Part 0: Test-case updates. r=mjf
https://hg.mozilla.org/integration/autoland/rev/1fb8d0d598d0
Part 1: Parse simulcast without rid= or pt= r=mjf

Comment 14

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/17c6c03c439e
https://hg.mozilla.org/mozilla-central/rev/1fb8d0d598d0