1470568 - Stop supporting "rid=" in simulcast attributes once ESR doesn't serialize it anymore

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, enhancement, P3)

Comment 1

[Byron Campen [:bwc]]

It probably makes sense to do this before trying to implement the [[SendEncodings]] stuff from bug 1401592.

Comment 2

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=24f1a257c8e3d03f4a32a142743be8042e738984

Comment 3

[Byron Campen [:bwc]]

Attachment: Bug 1470568: Remove the rid= and pt= stuff from our simulcast parsing. Also, handle paused rids correctly. r?mjf

Comment 4

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=488a9215659dc5e1d34231a94978156b44afed01

Comment 5

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ac5e995ac0e521ff723d64a090acc157553ba1c

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2fca72b71c56
Remove the rid= and pt= stuff from our simulcast parsing. Also, handle paused rids correctly. r=mjf

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/2fca72b71c56

Comment 8

[Daniel Holbert [:dholbert]]

note, this seems to have broken meet.google.com -- see bug 1586423.

Comment 9

[Andreas Pehrson [:pehrsons]]

Since this is a breaking change for multiple conferencing services, we at the very least need a relnote for developers on this.

Comment 10

[Kohei Yoshino]

Posted site compatibility note: https://www.fxsitecompat.dev/en-CA/docs/2019/pt-and-rid-in-webrtc-simulcast-attributes-are-no-longer-supported/

Comment 11

[Kohei Yoshino]

Updating the flag as per Bug 1586423.

Comment 12

[Mathew Hodson]

We should probably reopen this bug since the change has been completely reverted.

Comment 13

[Byron Campen [:bwc]]

It sounds like meet and whereby are both working again here. I'm going to land this again.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8c4bc326f3c7
Remove the rid= and pt= stuff from our simulcast parsing. Also, handle paused rids correctly. r=mjf

Comment 15

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/8c4bc326f3c7

Comment 16

[Kohei Yoshino]

Updated the site compatibility note.

Comment 17

[Eric Shepherd [:sheppy]]

Documentation notes: this is about removing attributes from the SDP used in simulcast which were only used in very old versions of the specification for simulcast. They were removed in version 4 of this specification: https://tools.ietf.org/html/draft-ietf-mmusic-sdp-simulcast-14

From a documentation perspective, this probably just needs a mention that connectivity with very older clients may no longer work until those are updated. We actually have no content at all on MDN yet about simulcast.

Comment 18

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

This regresses fippo's simulcast fiddle. https://jsfiddle.net/jib1/qcwe1t86/

Is this intentional? Is it salvageable?

Comment 19

[Byron Campen [:bwc]]

You should be able to remove the "rid=" from that fiddle.

Comment 20

[Eric Shepherd [:sheppy]]

Noted on Firefox 72 for developers. We have no other documentation that covers this subject yet, so no further changes are needed.