1226040 - [e10s] dragging images sometimes works, sometimes doesn't

Status: RESOLVED WORKSFORME

(Core :: DOM: Copy & Paste and Drag & Drop, defect, P2)

Description

[The 8472]

Dragging images from a webpage to windows explorer ceases to work without apparent cause.

Even when starting to drag the image it doesn't show the half-transparent version that gets dragged along.

Opening a new tab and dropping a file from the explorer into it somehow seems restore the functionality until it fails again at a later point in time.

These messages popped in the browser console, maybe related:

00:55:08.220 TypeError: sourceDocument.defaultView is null contentAreaDropListener.js:123:11
00:55:13.735 Security Error: Content at moz-nullprincipal:{bb0c7097-22ca-4e70-95a9-ec3e920d05f4} may not load or link to file:///<anonymized>


Is there any additional debug information I can gather when this happens?

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Hey The 8472, the error you've brought up is being fired when you drop an image onto the browser, but your report is about dragging images out of the browser.

Can you help clear up what this bug is about by recording a short screencast of yourself demonstrating the bug, and posting it in here?

Comment 2

[The 8472]

The issue is about dragging things out of the browser. Like I said I simply tried dropping things into the browser to see whether that is or isn't working either. I guess that must have triggered the log message then and thus probably isn't related to my issue.

I'll record a video when the problem occurs again.

Comment 3

[The 8472]

Attachment: drag and drop.webm

You can't see my mouseclicks but the video shows the following:

1. several attempts to drag an image out of the browser. note that the partially transparent drag-overlay does not appear
2. drop from explorer into the browser in a new tab
3. drag suddenly works again

I hope that clarifies the symptoms i'm seeing.

Comment 4

[The 8472]

Now i'm seeing the following error message on the console:
 
NS_ERROR_NOT_IMPLEMENTED: Component returned failure code: 0x80004001 (NS_ERROR_NOT_IMPLEMENTED) [nsIHandlerInfo.description] nsHandlerService.js:320:0

There is one for each drag attempt and it happens on different websites, so it's unlikely to caused by a website's JS.

Comment 5

[Jim Mathies [:jimm]]

Do you have addons installed? If so can you try reproducing with addons disabled to see if it helps?

Comment 6

[Jim Mathies [:jimm]]

I also see this when dragging an image, but it doesn't interfere with the drag - 

08:46:24.207 NS_ERROR_NOT_IMPLEMENTED: Component returned failure code: 0x80004001 (NS_ERROR_NOT_IMPLEMENTED) [nsIHandlerInfo.description]1 nsHandlerService.js:320:0

Comment 7

[The 8472]

> Do you have addons installed?

Yes

> If so can you try reproducing with addons disabled to see if it helps?

Since the behavior is fairly intermittent, I do not know how to reliably trigger it and I don't drag images all day long I can only observe it occasionally when attempting to drag something in my regular browsing session, which I am not willing to use for a prolonged time without addons.

If I had a way of reproducing it quickly then I would try without addons of course.

----

Some possibly related behavior I'm seeing is that when I drag something into a browser it replaces the current tab's content with some recently visited or closed tab instead of the drop either loading the image or triggering a drop handler in the current page. This only happens during the transition from the broken state into the working-as-expected state. Subsequent drops work as expected.

Comment 8

[Jim Mathies [:jimm]]

Can you hook me up with your about:support?

Comment 9

[The 8472]

Attachment: about:support output

here you go

Comment 10

[Jim Mathies [:jimm]]

I tried adding Abuction and uMatrix locally. Didn't run into any issues. Greasemonkey is a likely culprit. Are you running a lot of gm scripts?

Comment 11

[The 8472]

A bunch of site-specific ones, but non-greased sites are affected too. Is there any particular component in GM that would affect drag?

As far as I can tell from the GM source it only installs a on-drop event handler in the chrome, not a drag handler.

Comment 12

[Jim Mathies [:jimm]]

blake offered to take a look at this.

Comment 13

[Jim Mathies [:jimm]]

I haven't had much time for this and probably won't until the new year. I think this is extension related though (possibly greasemonkey related) as I have not been able to reproduce without extensions installed. Kicking this back out to triage to find a new owner.

Comment 14

[The 8472]

> as I have not been able to reproduce without extensions installed.

Were you able to reproduce it at all?

If not, is there anything I gather on my end?

Comment 15

[Jim Mathies [:jimm]]

(In reply to The 8472 from comment #14)
> > as I have not been able to reproduce without extensions installed.
> 
> Were you able to reproduce it at all?
> 
> If not, is there anything I gather on my end?

No I wasn't able to reproduce. There's another bug related to this too, bug 1231429, which is non-e10s.

Comment 16

[Blake Kaplan (:mrbkap) (inactive)]

This is probably related to bug 1226040.

Comment 17

[The 8472]

(In reply to Blake Kaplan (:mrbkap) (please use needinfo!) from comment #16)
> This is probably related to bug 1226040.

I'm experiencing infinite recursion here ;)

Comment 18

[Blake Kaplan (:mrbkap) (inactive)]

(In reply to The 8472 from comment #17)
> (In reply to Blake Kaplan (:mrbkap) (please use needinfo!) from comment #16)
> > This is probably related to bug 1226040.
> 
> I'm experiencing infinite recursion here ;)

Erm, bug 1183915. Sorry about that! I hope you break out before your stack overflows.

Comment 19

[Blake Kaplan (:mrbkap) (inactive)]

I'm hoping the patch in bug 1183915 fixes this. The 8472, can you try your STR with one of the builds produced by the try push at [1] when they're available?

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=a3fa9c8d9602

Comment 20

[The 8472]

Sure, i'll give it a try. It'll take a while to confirm though since I'm not seeing it frequently.

Comment 21

[The 8472]

Ah, actually, there is no windows x64 build. I can't test with 32bit due to virtual address space exhaustion.

Comment 22

[Mike Conley (:mconley) (:⚙️)]

I've triggered a 64-bit Windows debug build on the same push. Should be available in a few hours.

Comment 23

[Mike Conley (:mconley) (:⚙️)]

Whoops, forgot to ni.

Comment 24

[The 8472]

There only is a logfile for the x64 build on archive.mozilla.org, no binaries.

Maybe I should just wait until bug 1183915 makes its way into nightly?

Comment 25

[Blake Kaplan (:mrbkap) (inactive)]

Yeah, that's fine.

Comment 26

[The 8472]

The issue is still occurring in  Build ID 20160224030246, does that contain the patch from the other bug?

Comment 27

[Blake Kaplan (:mrbkap) (inactive)]

The patch missed that build by 2 minutes, today's nightly has it.

Comment 28

[The 8472]

Ok, it's still happening in build 20160225030209

Comment 29

[The 8472]

During a more intense image-hunting session I have observed a whole cluster of symptoms which I suspect of having a common cause:

- dragging picks up an image that's not under the current mouse pointer
 - something on the same page, but different scroll position
 - something from a different tab
 - something from a previously-visited page on the same tab
- dropping from the file manager into a browser form element causes erratic effects
 - loads a previously visited page, possibly from a different tab
 - loads a previously dragged image, possibly from a different tab, as top-level URL
- dragging from the browser doesn't work at all until something gets dropped into the tab [the initially reported issue]
- dropping from file manager doesn't work, shows the "can't drop here" mouse icon, reloading the page solves that [potentially not a browser bug, could be something with the JS on the page, I'm still listing it since it fits into the cluster]

Those symptoms only occur intermittently, only affect some tabs and either only occur once or go away by performing a specific action. So my guess is that some internal state relating to DnD gets desynchronized/glitched and the next action puts it into a well-defined state again.


I don't have precise STR since I exercise a fairly broad set of browser features while hunting for images.

Non-exhaustive list, in no particular order:

- spawning background tabs via middle-click
- aborting drags via the ESC key
- back-forward navigation
- dragging images from gallery pages into the file manager [pages have some dynamic gallery features like inline-expansion and infinite scroll]
- switching tabs
- dropping images from file manager into a form [form is dynamic, showing image previews, uploading via XHR, actually has drop handler installed on the whole page, not just the form field itself]

Comment 30

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Firefox: 48.0a1, Build ID: 20160328030215
User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:48.0) Gecko/20100101 Firefox/48.0

Hi,

I have tested this issue on the latest Nightly (48.0a1) build and I have manged to reproduce it a few times, but I don't know which are the exact steps to reproduce it. It seems that it is randomly reproducible. Mostly I have reproduced it when I opened some large images with middle click in new tabs and rapidly zooming in and out a few times. Then switching tabs or opening a new image is causing the problem. Sometimes I can not use drag and drop on all tabs, util I drop an image from my computer or reset Firefox. 
Also, I have reproduced it when I returned on a old opened tab with an image, but still I am not sure what are the exact steps.
   
I have also tested this on windows 8 x32 and Ubuntu 14.04 and managed to reproduce it randomly.

Thanks,
Cosmin.

Comment 31

[Tracy Walker [:tracy]]

I've messed around with this quite a bit now in attempt to dial in some reproducible steps.  I think I have steps that one could use to eventually reproduce a form of drag and drop corruption on Windows.

STR:

0) have a largish image on the desktop. (I used one 740Kb)
1) drag the image from the desktop to tab 1
2) Open a new tab, then Drag the image from the desktop to tab 2
3) Rapidly zoom in and out by clicking in the image 5 times to leave it zoomed in
4) quickly DnD the image from tab 2 to the desktop (choose to replace the existing image)
5) reload tab 1

Test results: The image is corrupted; only the top 25-30% of the original image is displayed. (note: speed in steps 3 and 4 do seem to be a factor.  if you do these steps slowly, the bug doesn't repro)

If you continue to DnD the image from the desktop to a tab, zoom in and out, then quickly DnD the image back to the desktop, eventually, randomly the DnD wipes the image from the desktop and the image is not found on tab reload. This last effect is very bad as it is data loss.

I tested with recent versions of Nightly on (update is not currently working)
Win 7, Nightly 48.0a1 20160324030447 - Reproduced image corruption and occasionally lost desktop image.
Mac, Nightly 48.0a1 20160328030215 - can't reproduce as the OS automatically makes a copy of the image instead of offering an option to replace
Ubuntu, Nightly 48.0a1 20160325030241 - same as Mac, the OS automatically makes an image copy.

Comment 32

[Ryan VanderMeulen [:RyanVM]]

Given that this reproduces on Linux, I'm wondering if someone could try catching it under rr with the steps provided.

Comment 33

[The 8472]

Closing since I haven't seen the issue for quite some town.