1226130 - "Clear private data on exit" option is visible in restricted profile

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[u549602]

Attachment: Settings menu comparison between Aurora and Nightly.jpg

Environment: Nightly
Device: Sony Xperia Z2 (Android 5.0.2);
Build: Nightly 45.0a1 (2015-11-18);

Steps to reproduce:
1. Owner sets "Clear private data" to disabled
2. User logs in Restricted profile and visits Settings - Privacy


Expected result:
"Clear private data on exit" option is not visible in the Privacy menu

Actual result:
"Clear private data on exit" option is available in the Privacy menu and functions as it wasn't disabled

For further details please check: https://www.youtube.com/watch?v=3GoiWowsH1U&feature=youtu.be

Comment 1

[:Margaret Leibovic]

This is probably a regression from the settings reorg work...

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1226130 - GeckoPreferences: Process PrefHandlers last. r?margaret

Bug 1226130 - GeckoPreferences: Process PrefHandlers last. r?margaret

A restriction might remove the preference, so we want to remove it first and only
call the PrefsHandler if the preference is still visible.

Comment 3

[:Margaret Leibovic]

Comment on attachment 8692958 [details]
MozReview Request: Bug 1226130 - GeckoPreferences: Process PrefHandlers last. r?margaret

https://reviewboard.mozilla.org/r/26365/#review23817

::: mobile/android/base/preferences/GeckoPreferences.java:857
(Diff revision 1)
> +                    PrefHandler handler = handlers.get(key);

It could be good to leave a comment here about why we want to do this last.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/19c3d08e8304f13070270c23bd099c0179494255
Bug 1226130 - GeckoPreferences: Process PrefHandlers last. r=margaret

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/19c3d08e8304

Comment 6

[u549602]

Please note that the dependency on bug 1230937 is still valid since the crash when launching Aurora in restricted profile reproduces. Also, this issue could not be verified on Aurora and a new issue ( https://bugzilla.mozilla.org/show_bug.cgi?id=1234185 ) was added for the new Nightly build (46.0a1) on which the "clear data on exit" option displayed in restricted profile still could be reproduced.

Comment 7

[u549602]

Verified as fixed on the latest Aurora build (45.0a2 07-01-2016), on a Samsung Galaxy Tab S2 with Android 5.0.2