1230937 - Nightly crashes in restricted profile

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[u549602]

Environment: Nightly
Device: Sony Xperia z2 (Android 5.0.2 );
Build: Nightly 45.0a1 (2015-12-07);

Steps to reproduce:
1. Have the Nightly build installed and restricted profile active
2. Log in restricted profile and open Nightly

Expected result:
Nightly should properly be opened and running

Actual result:
Scenario 1 :Nightly crashes
Scenario 2: Nightly opens but it is unresponsive, no default tabs are opened and no buttons work. After a while "Nightly isn't responding. Do you want to close it" message is displayed 

Note: Possible regression caused by the fix of https://bugzilla.mozilla.org/show_bug.cgi?id=1226130


 http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=039a8490891595736b16a3ccb17f025f4dcf13eb&tochange=47b49b0d32360fab04b11ff9120970979c426911

Comment 1

[u549602]

Please review the ADB logs for further details here https://pastebin.mozilla.org/8854017.
Crash-report link from logs returns an invalid crash id

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

NullPointerException: Attempt to invoke virtual method 'boolean java.lang.Boolean.booleanValue()' on a null object reference
  at org.mozilla.gecko.restrictions.RestrictedProfileConfiguration.isAllowed(RestrictedProfileConfiguration.java:80)
  at org.mozilla.gecko.Restrictions.isAllowed(Restrictions.java:109)
  [..]

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1230937 - Restricted profiles: Always allow features that are not in the configuration. r?margaret

Bug 1230937 - Restricted profiles: Always allow features that are not in the configuration. r?margaret

Comment 4

[:Margaret Leibovic]

Comment on attachment 8698414 [details]
MozReview Request: Bug 1230937 - Restricted profiles: Always allow features that are not in the configuration. r?margaret

https://reviewboard.mozilla.org/r/27981/#review25057

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/bbe415dff6006d3d2197e4d180807054a4f78aa9
Bug 1230937 - Restricted profiles: Always allow features that are not in the configuration. r=margaret

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8698414 [details]
MozReview Request: Bug 1230937 - Restricted profiles: Always allow features that are not in the configuration. r?margaret

Approval Request Comment

[Feature/regressing bug #]: Regression introduced in bug 1189336.

[User impact if declined]: Firefox crashes when used in a restricted profile.

[Describe test coverage new/current, TreeHerder]: Local testing; No support for UI tests in restricted profiles yet.

[Risks and why]: Low. Crash trigger by unhandled restrictions. Patch will allow all unknown features in restricted profiles.

[String/UUID change made/needed]: -

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/fx-team/rev/044a0f3fca16 for rc3 failures like https://treeherder.mozilla.org/logviewer.html#?job_id=6205590&repo=fx-team

(Also backed out bug 1222377 for this since I couldn't tell which was at fault.)

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

Failure caused by bug 1222377. I'll re-land this one.

Comment 9

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/5ac640a116e12ec1dc1828f53b248adeb9297911
Bug 1230937 - Restricted profiles: Always allow features that are not in the configuration. r=margaret

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5ac640a116e1

Comment 11

[u549602]

Verified as fixed on latest Nightly build (46.0a1 / 2015-12-20) on Nexus 7 with Android 5.1.1, Samsung Galaxy Tab S2 with Android 5.0.2 and Nexus 9 with Android 6.0.

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8698414 [details]
MozReview Request: Bug 1230937 - Restricted profiles: Always allow features that are not in the configuration. r?margaret

Fix a crash. Verified, taking it.

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/38b1c0eaa902

Comment 14

[u549602]

Verified as fixed on the latest Aurora Build (45.0a2 07-01-2016), using a Samsung Galaxy Tab S2 with Android 5.0.2