1226301 - Remove unused shumway code from nightly and b2gdroid builds

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Margaret Leibovic]

According to yury, there are no near-term plans to bundle shumway with mobile. It's already disabled, let's just remove the code to avoid worrying about it.

Comment 1

[Mike Taylor [:miketaylr]]

I'm gonna steal this as an easy 2016-get-unrusty-with-moz-central bug.

Comment 2

[Mike Taylor [:miketaylr]]

Updating title because b2gdroid has some stuff copied over from fennec, might as well nuke 'em both.

Comment 3

[Mike Taylor [:miketaylr]]

Attachment: 1226301.-Remove-Shumway-from-Fennec-nightly-buil.patch

Is it OK to leave an empty moz.build in the m/a/extensions? Or should we just remove the entire directory?

Comment 4

[Mike Taylor [:miketaylr]]

Attachment: 1226301.-Remove-Shumway-from-b2gdroid-nightly-bu.patch

Comment 5

[Mike Taylor [:miketaylr]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=056bd8ecba32

Comment 6

[:Margaret Leibovic]

(In reply to Mike Taylor [:miketaylr] from comment #3)
> Created attachment 8703683 [details] [diff] [review]
> 1226301.-Remove-Shumway-from-Fennec-nightly-buil.patch
> 
> Is it OK to leave an empty moz.build in the m/a/extensions? Or should we
> just remove the entire directory?

I think we should just remove the entire directory. It was created when Shumway support was added in bug 905668.

Comment 7

[Mike Taylor [:miketaylr]]

Cool, will update the patch.

Comment 8

[Mike Taylor [:miketaylr]]

Attachment: 1226301.-Remove-Shumway-from-Fennec-nightly-buil.patch

Comment 9

[[:fabrice] Fabrice Desré]

Comment on attachment 8703684 [details] [diff] [review]
1226301.-Remove-Shumway-from-b2gdroid-nightly-bu.patch

Review of attachment 8703684 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, thanks!

Comment 10

[:Margaret Leibovic]

Comment on attachment 8703742 [details] [diff] [review]
1226301.-Remove-Shumway-from-Fennec-nightly-buil.patch

Review of attachment 8703742 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9c35c77c63e4
https://hg.mozilla.org/integration/mozilla-inbound/rev/909fd29a0adf

Comment 12

[Nigel Babu [:nigelb]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/caceae579a499ab3da50b02cd0d0e46d98495bee
Bug 1226301 - Follow up to fix bustage, r=bustage ON A CLOSED TREE

Comment 13

[Mike Taylor [:miketaylr]]

D'oh. Sorry about that Nigel-- and thx for the fix!

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9c35c77c63e4
https://hg.mozilla.org/mozilla-central/rev/909fd29a0adf
https://hg.mozilla.org/mozilla-central/rev/caceae579a49