Closed Bug 1226301 Opened 4 years ago Closed 4 years ago

Remove unused shumway code from nightly and b2gdroid builds

Categories

(Firefox for Android :: General, defect)

35 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 46
Tracking Status
firefox46 --- fixed

People

(Reporter: Margaret, Assigned: miketaylr)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

According to yury, there are no near-term plans to bundle shumway with mobile. It's already disabled, let's just remove the code to avoid worrying about it.
I'm gonna steal this as an easy 2016-get-unrusty-with-moz-central bug.
Assignee: nobody → miket
Updating title because b2gdroid has some stuff copied over from fennec, might as well nuke 'em both.
Summary: Remove unused shumway code from nightly builds → Remove unused shumway code from nightly and b2gdroid builds
Is it OK to leave an empty moz.build in the m/a/extensions? Or should we just remove the entire directory?
Attachment #8703683 - Flags: review?(margaret.leibovic)
(In reply to Mike Taylor [:miketaylr] from comment #3)
> Created attachment 8703683 [details] [diff] [review]
> 1226301.-Remove-Shumway-from-Fennec-nightly-buil.patch
> 
> Is it OK to leave an empty moz.build in the m/a/extensions? Or should we
> just remove the entire directory?

I think we should just remove the entire directory. It was created when Shumway support was added in bug 905668.
Cool, will update the patch.
Attachment #8703683 - Attachment is obsolete: true
Attachment #8703683 - Flags: review?(margaret.leibovic)
Attachment #8703742 - Flags: review?(margaret.leibovic)
Comment on attachment 8703684 [details] [diff] [review]
1226301.-Remove-Shumway-from-b2gdroid-nightly-bu.patch

Review of attachment 8703684 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm, thanks!
Attachment #8703684 - Flags: review?(fabrice) → review+
Comment on attachment 8703742 [details] [diff] [review]
1226301.-Remove-Shumway-from-Fennec-nightly-buil.patch

Review of attachment 8703742 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8703742 - Flags: review?(margaret.leibovic) → review+
D'oh. Sorry about that Nigel-- and thx for the fix!
You need to log in before you can comment on or make changes to this bug.